Skip to content

Bug: Right pane height is too tall #50

Closed
@nzakas

Description

@nzakas

What did you do?

Viewed the AST tree and expanded as far as I could. (This also happens in Scope view.)

What did you expect to happen?

The scrollbar goes off the bottom of the screen and there is no space between the last tree item and bottom of the screen.

What actually happened?

Image

(Looks like maybe the vertical sizing of the right panel is incorrect because the scrollbar is being cut off at the bottom?)

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response

Activity

added
bugSomething isn't working
repro:neededThis issue should include a reproducible example
on Sep 27, 2024
changed the title [-]Bug: Missing space on top of first tree item[/-] [+]Bug: Missing space on top of first tree item and bottom of last tree item[/+] on Sep 27, 2024
added
acceptedThere is consensus among the team that this change meets the criteria for inclusion
on Sep 27, 2024
changed the title [-]Bug: Missing space on top of first tree item and bottom of last tree item[/-] [+]Bug: Right pane height is too tall[/+] on Sep 27, 2024
nzakas

nzakas commented on Sep 27, 2024

@nzakas
MemberAuthor

Actually, it looks like the left pane has the same problem:
Image

nzakas

nzakas commented on Sep 27, 2024

@nzakas
MemberAuthor

It looks like this is at least partly related to the border at the top of the page. We probably need to revisit how the page layout is structured.

amareshsm

amareshsm commented on Sep 27, 2024

@amareshsm
Member

It looks like this is at least partly related to the border at the top of the page. We probably need to revisit how the page layout is structured.

We need to update the layout height calculation part. I will look into this issue.
Image

self-assigned this
on Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

acceptedThere is consensus among the team that this change meets the criteria for inclusionbugSomething isn't workingrepro:neededThis issue should include a reproducible example

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @nzakas@amareshsm

    Issue actions

      Bug: Right pane height is too tall · Issue #50 · eslint/code-explorer