Skip to content

Suggestion: use one level accordions for items inside the right pane #71

Closed
@harish-sethuraman

Description

@harish-sethuraman
Member

What problem do you want to solve?

Currently there are two levels of accordion for values inside the tree. We might want to reduce it to one level. I don't see a necessity for having two levels of accordion. We can possibly remove the accordion inside and replace it with the + and - similar to astexplorer. This way it would be easier for us to enable the auto opening of accordions on right pane based on active line in left panel (ref). Raised this issue to understand if we are benefiting anything over having two levels of accordions.

What do you think is the correct solution?

  • find why we have two accordions
  • replace two levels of accordion with just one level

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

Activity

nzakas

nzakas commented on Oct 21, 2024

@nzakas
Member

I'm guessing this is because we still wanted to have the heading on each object. Can you share an image of how you'd imagine changing this?

harish-sethuraman

harish-sethuraman commented on Oct 21, 2024

@harish-sethuraman
MemberAuthor

This is how it looks without the accordion. The type information is already present on the expandable header on top.

Image

nzakas

nzakas commented on Oct 23, 2024

@nzakas
Member

To me that looks kind of broken. Could we remove the accordion but keep the same visual treatment we currently have? (With a header that doesn't expand/collapse?)

harish-sethuraman

harish-sethuraman commented on Oct 23, 2024

@harish-sethuraman
MemberAuthor

Sure that is possible. I'll make it default open and remove the accordion interaction from there.

added
acceptedThere is consensus among the team that this change meets the criteria for inclusion
on Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

acceptedThere is consensus among the team that this change meets the criteria for inclusionenhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @nzakas@harish-sethuraman

    Issue actions

      Suggestion: use one level accordions for items inside the right pane · Issue #71 · eslint/code-explorer