chore: review comments

Author: SwetaTanwar

src/rules/no-missing-atx-heading-space.js

@@ -17,6 +17,7 @@
 //-----------------------------------------------------------------------------
 
 const HEADING_PATTERN = /^(#{1,6})(?:[^#\s])/u;
+const NEW_LINE_PATTERN = /\r?\n/u;
 
 //-----------------------------------------------------------------------------
 // Rule Definition
@@ -53,7 +54,7 @@ export default {
 					}
 
 					const text = context.sourceCode.getText(firstTextChild);
-					const lines = text.split(/\r?\n/u);
+					const lines = text.split(NEW_LINE_PATTERN);
 
 					lines.forEach((line, idx) => {
 						const lineNum =

tests/rules/no-missing-atx-heading-space.test.js

@@ -36,6 +36,10 @@ const validHeadings = [
 	"##### Heading 5",
 	"###### Heading 6",
 
+	// 1.1 ATX heading-like text
+	"####### Heading 7 (not a valid heading)",
+	"#######Heading 7 (not a valid heading)",
+
 	// 2. Document with multiple headings
 	dedent`# Heading 1
 
@@ -45,6 +49,7 @@ const validHeadings = [
 
 	// 3. Variations on spacing
 	"#  Heading with extra space",
+	"#\tHeading with tab",
 
 	// 4. Standalone hash
 	"#",
@@ -66,22 +71,23 @@ const validHeadings = [
 	"```",
 
 	// 7.3 Code blocks with language identifiers
-	"``` followed by text",
-	"~~~ followed by more text",
+	"``` #followed #by text",
+	"~~~ #followed #by more text",
 
 	// 7.4 Code block after paragraph
 	dedent`This is a paragraph followed by code.
 	
-\`\`\`
-#This is in a code block
-\`\`\``,
+	\`\`\`
+	#This is in a code block
+	\`\`\``,
 
 	// 8. Inline code with hash symbols
 	"This paragraph has `#inline-code` which is not a heading",
 	"Here's a code span with a hash: `const tag = '#heading'`",
 
 	// 9. Markdown links with hash in URLs
 	"[#370](https://github.com/eslint/markdown/issues/370)",
+	"![#370](https://github.com/eslint/markdown/image.png)",
 
 	// 10. HTML headings (not ATX-style)
 	"<h1>Heading 1</h1>",
@@ -91,6 +97,7 @@ const validHeadings = [
 	"<h5>Heading 5</h5>",
 	"<h6>Heading 6</h6>",
 	"<h1>#valid heading</h1>",
+	"<!-- #valid heading -->",
 
 	// 11. Content inside single quotes and double quotes
 	`'#something'`,
@@ -296,11 +303,11 @@ const invalidTests = [
 	// 5.1 With code markers in context
 	{
 		code: dedent`Text before
-#Heading with \`\`\` code markers
-Text after`,
+		#Heading with \`\`\` code markers
+		Text after`,
 		output: dedent`Text before
-# Heading with \`\`\` code markers
-Text after`,
+		# Heading with \`\`\` code markers
+		Text after`,
 		errors: [
 			{
 				messageId: "missingSpace",