-
Notifications
You must be signed in to change notification settings - Fork 73
feat: create no-duplicate-definitions
#360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
defaultOptions: [ | ||
{ | ||
ignoreDefinition: ["//"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//
is usally used as a definition-style comment.
References:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! Would like @fasttime to review before merging.
Thanks for all your reviews! I've pushed a few more commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Would like @fasttime and @snitin315 to verify their feedback before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just a small suggestion, totally optional and not blocking the merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving.
Prerequisites checklist
What is the purpose of this pull request?
Hello,
I’ve finished implementing no-duplicate-definitions.
I’ve left some comments on some notable parts of the code.
What changes did you make? (Give an overview)
I’ve finished implementing no-duplicate-definitions.
Related Issues
closes: #358
Is there anything you'd like reviewers to focus on?