-
Notifications
You must be signed in to change notification settings - Fork 73
feat: add no-missing-atx-heading-space rule #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add no-missing-atx-heading-space rule #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please take a look at the CI failures?
I think there might be some edge cases that were missed.
Fixed the edge case for markdown lint 0a7f1ec |
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
How about |
Agreed, updating the rule name to |
Would it be better to use CommonMark Spec and Mdast use |
@lumirlumir yes, good call. We should use "heading" instead of "header". By the way, you don't have to set assignees on PRs. it's assumed the author is the assignee. |
37c31f5
to
73001bb
Compare
@lumirlumir I have addressed your feedback, PTAL |
5c4dca9
to
41124d0
Compare
41124d0
to
f1f8aaf
Compare
I apologize if my review comments came across as a bit aggressive. My English is still a work in progress, so there may have been some unintended tone. I’ll make sure to use kinder wording next time. I’ll review it in a few days — thank you in advance for your patience! |
@lumirlumir, No worries at all — I didn’t find the tone off in any way. Really appreciate your comments, they helped catch some important cases I missed. Looking forward to your next round of feedback when you get a chance! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your hard work and patience on this PR.
Would like to ask @snitin315 and @nzakas to re-verify before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for contributing ⭐
Prerequisites checklist
What is the purpose of this pull request?
This PR adds a new rule
no-missing-atx-heading-space
to ensure there is a space after hash on ATX style headings in MarkdownWhat changes did you make? (Give an overview)
Added the
no-missing-atx-heading-space
rule, along with documentation and tests.Related Issues
fixes #370
Is there anything you'd like reviewers to focus on?
Screenshots