fix(pdp): s/piece_cid/pieceCid to make JSON response casing consistent #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is the only place in the pdp handlers where we have _'s
rvagg
added a commit
to FilOzone/synapse-sdk
that referenced
this pull request
Jun 23, 2025
Also handle the piece_cid -> pieceCid transition Ref: filecoin-project/curio#547
rvagg
added a commit
to FilOzone/synapse-sdk
that referenced
this pull request
Jun 24, 2025
Also handle the piece_cid -> pieceCid transition Ref: filecoin-project/curio#547
virajbhartiya
pushed a commit
to virajbhartiya/synapse-sdk
that referenced
this pull request
Jun 24, 2025
Also handle the piece_cid -> pieceCid transition Ref: filecoin-project/curio#547
ZenGround0
approved these changes
Jun 24, 2025
virajbhartiya
pushed a commit
to virajbhartiya/synapse-sdk
that referenced
this pull request
Jun 25, 2025
Also handle the piece_cid -> pieceCid transition Ref: filecoin-project/curio#547
virajbhartiya
pushed a commit
to virajbhartiya/synapse-sdk
that referenced
this pull request
Jul 3, 2025
Also handle the piece_cid -> pieceCid transition Ref: filecoin-project/curio#547
rvagg
added a commit
to virajbhartiya/synapse-sdk
that referenced
this pull request
Jul 4, 2025
Also handle the piece_cid -> pieceCid transition Ref: filecoin-project/curio#547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only place in the pdp handlers where we have _'s. This is probably good to fix earlier than later. On the client side, in my code at least, I'll make it accept both forms for now and remove the older form when we think we have it rolled out properly.