Adds small onboarding missing documentation #1518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaelGNM
approved these changes
Jun 18, 2025
johnduffell
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
nice one, thanks for constantly making the docs better for the next person! 👏
regarding the PR descipriton, generally the template is just a prompt, so I would recommend to remove parts that are not adding value. Then it reduces the time spent to review for your team mates. In this case I think you could replace the whole description with "This PR adds a missing documentation line found during my onboarding process"
|
Seen on PROD (merged by @j-ruda-guardian 10 minutes and 35 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small missing documentation line found during my onboarding process