-
-
Notifications
You must be signed in to change notification settings - Fork 807
Backchannel Logout #1573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Backchannel Logout #1573
Conversation
Before going further with this PR and working on tests/documentation, could please someone comment about the general structure of the implementation? My main concerns:
|
|
|
36a433e
to
4aeac81
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1573 +/- ##
==========================================
- Coverage 97.38% 96.06% -1.32%
==========================================
Files 34 35 +1
Lines 2214 2315 +101
==========================================
+ Hits 2156 2224 +68
- Misses 58 91 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4aeac81
to
8750834
Compare
|
- Add migration to add backchannel logout support - Add model for Logout Token - Add admin for Logout Token - Add parameters related to backchannel logout on OIDC Discovery View - Change application creation and update form - Change template that renders information about the application -
b89d426
to
d3c2684
Compare
@lullis it looks like the next step is expanding test coverage right now the patch is just shy of 70%, our target is 100% coverage on patches going forward. At the very least we aim to match the current total coverage. |
@dopry this coverage report seems to be stale and based on a previous commit. How can I re-run the coverage report? |
It seems something has changed with the jazzband Codecov account and our codecov uploads are getting rate limited. I don't have the necessary permissions to add a the codecov repository upload token to the repo secrets and update our CI to use it. We're working on transferring out of jazzband right now to get away from those types of restrictions. In the meantime I'll keep trying to rerun the build to get coverage uploaded. |
I will take a look to see if I can run the report of the diff locally. Running coverage for the whole report showed that all files touched were at least at 99% coverage. |
Fixes #1545
Description of the Change
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS