Support displaying a message in case of a Twilio exception #315
Description
Expected Behavior
I would like to propose to give a change to developers to display a configured message in the settings, in case a Twilio exception happens. Like for example "Unable to create record: The 'To' number +4900000000000 is not a valid phone number.".
It may ocurre if a phone number is incorrectly setup.
Current Behavior
An exception is raise by the Twilio Client, meaning we get an internal error response.
Possible Solution
In case a settings variable like for instance:
TWILIO_ERROR_MESSAGE = 'Some error message'
We display the message using Django's message framework. Otherwise we keep the current behavior.
Steps to Reproduce (for bugs)
- Enable two factor for a user by configuring a false number for a user Ex: +4900000000000
- Try to login with the user's username and password.
- You should get an Internal Error response.
Context
I would like to show users a custom error message, instead of just a 500 or internal error page.
I would gladly make a pull request for this issue.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Participants
Activity
jazzband#315 display a message in case of a Twilio exception
jazzband#315 Update documentation in Twilio gateway class
jazzband#315 display a message in case of a Twilio exception
moggers87 commentedon Sep 30, 2019
I think we need a stacktrace - in most instance if generating a challenge fails the view catches it and sets
challenge_succeededin the template context. I would imagine we've just missed a place where this happens.Update unittest with changes of jazzband#315
Update unittest with changes of jazzband#315
yoandyshyno commentedon Oct 15, 2019
Also, for the Twilio gateway we can add the possibility to add a status callback url. This way, for instance, admins can track users that have devices unable to receive an SMS. This could be described in a new issue.