Skip to content

Added filtering to rules list #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Added filtering to rules list #33

wants to merge 5 commits into from

Conversation

dutzi
Copy link
Contributor

@dutzi dutzi commented Aug 4, 2015

No description provided.

@markelog
Copy link
Member

markelog commented Aug 8, 2015

I guess user could always do the ctrl+f bit, but it seems interesting.

Anyway, would you mind adding reflection of search input to the url? So people could pass those search queries?

@markelog
Copy link
Member

markelog commented Aug 8, 2015

If you decided to do it, you might want to wait on #35 since it would be much easier to implement with the "standart" route module

@dutzi
Copy link
Contributor Author

dutzi commented Aug 9, 2015

It's the first thing I was looking for when i encountered that page. I just like it when I can see all things related to something ("spaces", "anonymous", etc...) without scrolling.

I'm not too familiar with React, but sure I'll give it a shot.

@markelog
Copy link
Member

#35 is merged, it seems we can proceed with this

@dutzi
Copy link
Contributor Author

dutzi commented Aug 11, 2015

Done!

Conflicts:
	app/views/AppView/index.jsx
	app/views/pages/RuleListPageView/index.jsx
@markelog
Copy link
Member

Hey, sorry for the hold up, it turns out there was an issue with react-router, we fixed that only just now, tried to land this, but there is conflict with current dev, could you check it out?

Conflicts:
	app/views/AppView/index.jsx
	app/views/pages/RuleListPageView/index.jsx
@dutzi
Copy link
Contributor Author

dutzi commented Aug 15, 2015

np! merged it.

@markelog markelog closed this in ad5dda1 Aug 16, 2015
@markelog
Copy link
Member

Hm, it seems there is some problem at the npm run build execution -

/Users/arkel/Workspace/jscs-dev.github.io/node_modules/vow/lib/vow.js:104
            throw e;
                  ^
Error: Invariant Violation: You cannot modify a static location
    at invariant (/Users/arkel/Workspace/jscs-dev.github.io/node_modules/react/lib/invariant.js:42:15)
    at StaticLocation.throwCannotModify (/Users/arkel/Workspace/jscs-dev.github.io/node_modules/react-router/lib/locations/StaticLocation.js:10:3)
    at Function.replaceWith (/Users/arkel/Workspace/jscs-dev.github.io/node_modules/react-router/lib/createRouter.js:236:18)
    at [object Object].componentWillMount (/Users/arkel/Workspace/jscs-dev.github.io/app/views/AppView/index.jsx:25:29)
    at [object Object].ReactCompositeComponentMixin.mountComponent (/Users/arkel/Workspace/jscs-dev.github.io/node_modules/react/lib/ReactCompositeComponent.js:228:14)
    at [object Object].wrapper [as mountComponent] (/Users/arkel/Workspace/jscs-dev.github.io/node_modules/react/lib/ReactPerf.js:70:21)
    at Object.ReactReconciler.mountComponent (/Users/arkel/Workspace/jscs-dev.github.io/node_modules/react/lib/ReactReconciler.js:38:35)
    at [object Object].ReactCompositeComponentMixin.mountComponent (/Users/arkel/Workspace/jscs-dev.github.io/node_modules/react/lib/ReactCompositeComponent.js:247:34)
    at [object Object].wrapper [as mountComponent] (/Users/arkel/Workspace/jscs-dev.github.io/node_modules/react/lib/ReactPerf.js:70:21)
    at Object.ReactReconciler.mountComponent (/Users/arkel/Workspace/jscs-dev.github.io/node_modules/react/lib/ReactReconciler.js:38:35)

@dutzi
Copy link
Contributor Author

dutzi commented Aug 16, 2015

Fixed it in 8151a7e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants