Skip to content

Fix rules route #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix rules route #41

wants to merge 2 commits into from

Conversation

escaton
Copy link
Contributor

@escaton escaton commented Aug 18, 2015

No description provided.

@escaton
Copy link
Contributor Author

escaton commented Aug 18, 2015

@dutzi in #38 I had to change your way of reflecting search query in url, because gh-pages doesnt support smart routing, and your implementation requires server to send rules.html file for rules/%query% request.

cc @markelog I also add test/server.js to test pages after building, it should behave almost the same as gh-pages.

@dutzi
Copy link
Contributor

dutzi commented Aug 19, 2015

Oh... right, it makes much more sense the way you did it (using a query param).

@markelog markelog closed this in 269bd09 Aug 26, 2015
@markelog
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants