Implement fuzzy search. #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtambourine
changed the title
vtambourine
changed the title
|
I think it's better to do a simple search using concatenated title + summary. And I don't think we need markup in summary (at least for the highlighted items). |
|
@vtambourine Thanks so much for your original PR! Just closing out old issues/prs since we've merged with ESLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hzoo, please, consider my implementation of rules fuzzy search.
Here I run fuzzy search twice — first on rules name, second (among rules that didn't hit on the first run) on rules summary. Then I show two groups of matched rules together, with name matched on top. Here I tried to preserve original logic, but made it little more sane. Unfortunately, I am able to highlight only name, not summary, because of summary often contains markup.