Skip to content

Display "Click to add a cell" button as a part of notebook, not background #7565

Open
@andrii-i

Description

@andrii-i
Contributor

Problem

Currently "Click to add a cell" is rendered as a part of background / outer notebook area (grey in the JupyterLab light theme) under the drop shadow from the notebook / inner notebook area (white in the JupyterLab light theme).

To me it seems that the way how button is rendered in JupyterLab, as a part of notebook / inner notebook area (white in the JupyterLab light theme) is easier to read / parse. As an added bonus, this would make design language used in lab and notebook more consistent.

Notebook:
Image

JupyterLab:
Image

Proposed Solution

Render "Click to add a cell" button as a part of notebook / inner notebook area (white in the JupyterLab light theme).

In particular white space at the bottom of inner notebook area could be made larger to accommodate the button when hovering in a way that there would be no need to add / "pop-in" any artificial white space.

Image Image

It would make sense to add the same amount of white space to at the top of the notebook for visual balance.

Activity

jtpio

jtpio commented on Jan 21, 2025

@jtpio
Member

Thanks @andrii-i.

Isn't rendering the button as part of the notebook going to add some artificial white space at the bottom of the notebook, to accommodate for the button when hovering?

andrii-i

andrii-i commented on Jan 21, 2025

@andrii-i
ContributorAuthor

@jtpio thank you for looking into this. It would, I was thinking that white space at the bottom of inner notebook area could be made larger to accommodate the button when hovering in a way that there would be no need to add / "pop-in" any artificial white space.

added a commit that references this issue on Feb 17, 2025

Fix for issue jupyter#7565 on Click to add a cell button not to be in…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @jtpio@RRosio@andrii-i

      Issue actions

        Display "Click to add a cell" button as a part of notebook, not background · Issue #7565 · jupyter/notebook