Skip to content

[CIR][ThoughMLIR] Support ContinueOp in nested whiles #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CIR][ThoughMLIR] Support ContinueOp in nested whiles #1694

wants to merge 1 commit into from

Conversation

terapines-osc-cir
Copy link
Contributor

As we need to preserve the ContinueOp for inner loops when we convert for outer while-loops, we must not mark cir dialect as illegal. Otherwise, MLIR rejects this kind of preservation and considers it as a pass failure.
It seems we need another way to check whether the CIR is fully lowered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanza lanza Awaiting requested review from lanza lanza is a code owner

@bcardosolopes bcardosolopes Awaiting requested review from bcardosolopes bcardosolopes is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terapines-osc-cir @AdUhTkJm