Skip to content

[RISCV] RISCVTargetParserDef.inc doesn't get rebuilt when RISCVProcessors.td is modified #144639

@tclin914

Description

@tclin914

There are a couple of post-commit CI failures (#144022) after we made changes to the CPU definitions.

The reason is that RISCVTargetParserDef.inc does not get rebuilt when RISCVProcessors.td is modified, because the build rule for RISCVTargetParserDef.inc does not declare a dependency on RISCVProcessors.td, as shown in build.ninja.
See

for more details.

The CMake version should be less than 3.23; otherwise, it will use depfiles (.inc.d) instead.

Should we explicitly add all the .td files under llvm/lib/Target/RISCV/ as dependencies of RISCVTargetParserDef.inc , similar to file(GLOB_RECURSE global_tds "${LLVM_MAIN_INCLUDE_DIR}/llvm/*.td")?

Metadata

Metadata

Assignees

No one assigned

    Labels

    backend:RISC-VcmakeBuild system in general and CMake in particular

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions