Skip to content

Category Breadcrumb sort order #406

Closed
magento/commerce-data-export
#3
@magento-engcom-team

Description

@magento-engcom-team

GiftCard options sort order is wrong on MySQL 8

  • GiftCard options for specified amount should be sorted by by price ASC
  • saas-expoty may return data as is, but SF API should provide correct sort order
  • test fixed and unskipped in Magento\GiftCardProductDataExporter\Test\Integration\GiftCardProductTest::testGiftCardFixedAmountMultipleWebsites

Additionally:

  • rename rendertype "giftcardopenamount" to "giftcard_openamount"
  • for Specified Giftcard Amount:
    • add price to option value (productOptions.values.price field)
    • cover changes with tests (see  Magento\GiftCardProductDataExporter\Test\Integration\GiftCardProductTest::testGiftCardFixedAmountMultipleWebsites)
    • rename rendertype "drop_down" to "giftcardamount"

 

 

Test failed: 

 

PR: #403

 

Activity

magento-engcom-team

magento-engcom-team commented on Oct 26, 2020

@magento-engcom-team
Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/SFAPP-124

m2-assistant

m2-assistant commented on Oct 26, 2020

@m2-assistant

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


self-assigned this
on Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @mslabko@magento-engcom-team@aleksejsbaranovs10

    Issue actions

      Category Breadcrumb sort order · Issue #406 · magento/catalog-storefront