[Draft] Product override #17
Conversation
|
@magento run all tests |
|
|
||
| ## Release notes | ||
|
|
||
| *Magento_DataExporter* module |
There was a problem hiding this comment.
Nitpick: module name copied over here
| <filter glue="and"> | ||
| <condition attribute="entity_id" operator="in" type="placeholder">entityIds</condition> | ||
| </filter> | ||
| <link-source name="store_website"> |
There was a problem hiding this comment.
Is this the equivalent of
select cpip.entity_id, ..., sw.code as websiteCode from catalog_product_index_price cpip inner join store_website sw on sw.website_id = cpip.website_id
There was a problem hiding this comment.
true, join behavior can be changed through the instruction link type
| /** | ||
| * Product export feed indexer class | ||
| */ | ||
| class LegacyFeedIndexer implements IndexerActionInterface, MviewActionInterface |
There was a problem hiding this comment.
What makes a feed "legacy"? Is it because the queries are in code vs in XML?
If so, could it be possible to use either XML query or an in code query? There may be cases where XML is more limiting and a more complex query is needed.
There was a problem hiding this comment.
I have trouble finding a proper name, this particular class coupled to products and can not be reused, but in the future, I do want to have it at all. for now, removing could cause unnecessary refactoring ...
| <attribute name="final_price" alias="finalPrice"/> | ||
| <attribute name="min_price"/> | ||
| <filter glue="and"> | ||
| <condition attribute="entity_id" operator="in" type="placeholder">entityIds</condition> |
There was a problem hiding this comment.
I'm a little confused on how these get populated. How is the placeholder actually used in calling this?
| public function get(array $values): array | ||
| { | ||
| foreach ($values as $value) { | ||
| $queryArguments['entityIds'][] = $value['productId']; |
There was a problem hiding this comment.
Is this the injection of placeholders in the query XML?
There was a problem hiding this comment.
not exactly, it rather preparation of arguments that will be passed
| <attribute name="tax_class_id"/> | ||
| <attribute name="price" alias="regularPrice"/> | ||
| <attribute name="final_price" alias="finalPrice"/> | ||
| <attribute name="min_price"/> |
There was a problem hiding this comment.
Can we do JSON parsing selects here like feed_data->'$.prices.maximumPrice.finalPrice'?
There was a problem hiding this comment.
not now, but it is easy to add.
…e-data-export-16 [Imported] CatalogExportApi auto-generation
MDEE-40: change primary key
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Questions or comments
Code Review Checklist (*)