Skip to content

Reindex variants by child ids #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bricht
Copy link

@bricht bricht commented Nov 30, 2020

Description (*)

Makes reindexation more efficient by running it by variant child product ids.
Incorporates changes from
#11
and
#12

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Improve variants reindexation process. catalog-storefront#437

Questions or comments

Code Review Checklist (*)

  • Story AC is completed
  • proposed changes correspond to Magento Technical Vision
  • new or changed code is covered with web-api/integration tests (if applicable)
  • no backward incompatible changes

jekabs and others added 30 commits November 11, 2020 21:46
-Removed indexation reliance on product index
-Changed mview to product_relations
-Fixed indexing issues
-Plugin fix
-Added a dependency in indexer for testing purposes
This reverts commit 5ef8cfe.
-Static test fixes
-Slight cleanup
-Fixed the indexations to work with ee
-Syntax fixes
-Added child product to feed data
-Added indexer dependency
-Added improved variant deletion to the indexer
This reverts commit e02f9bd.
-Changed variable visibility to private
# Web-API tests fixes
 -Added product_id to variant integration test
This reverts commit 65f3bab.
-WebAPI fix
-Changed the variant indexation process to work around child product ids
@bricht
Copy link
Author

bricht commented Nov 30, 2020

@magento run all tests

@bricht
Copy link
Author

bricht commented Nov 30, 2020

@magento run all tests

1 similar comment
@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run Static Tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento import pr to magento-commerce/commerce-data-export

@magento-engcom-team
Copy link

@RuslanKostiv1 the pull request successfully imported.

@mmansoor-magento mmansoor-magento merged commit 7d785db into magento:main Dec 5, 2020
mmansoor-magento pushed a commit that referenced this pull request Jan 12, 2021
magento-devops-reposync-svc pushed a commit that referenced this pull request Jan 21, 2022
MDEE-77: Product Feed Indexer Performance Issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve variants reindexation process.
4 participants