Skip to content

Support for ratings & reviews in Storefront App #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Dec 10, 2020
Merged

Support for ratings & reviews in Storefront App #2

merged 28 commits into from
Dec 10, 2020

Conversation

aleksejsbaranovs10
Copy link
Contributor

@aleksejsbaranovs10 aleksejsbaranovs10 commented Nov 4, 2020 •
edited
Loading

Description (*)

Related Pull Requests

magento/storefront-product-reviews-ce#1
magento/catalog-storefront#415

Fixed Issues (if relevant)

  1. Fixes Support for ratings & reviews in Storefront App catalog-storefront#351

Questions or comments

Code Review Checklist (*)

  • Story AC is completed
  • proposed changes correspond to Magento Technical Vision
  • new or changed code is covered with web-api/integration tests (if applicable)
  • no backward incompatible changes

@aleksejsbaranovs
Support for ratings & reviews in Storefront App
eb10508 
- et_schema
- New feed tables
@aleksejsbaranovs
Support for ratings & reviews in Storefront App
2379303 
    - et_schema
@aleksejsbaranovs
Support for ratings & reviews in Storefront App
dff90f8 
- Removed customerId
@aleksejsbaranovs
Support for ratings & reviews in Storefront App
924304b 
- Separation in Import / Read reviews
@aleksejsbaranovs
Support for ratings & reviews in Storefront App
72e92c6 
- Review and rating metadata export
@aleksejsbaranovs
Support for ratings & reviews in Storefront App
5d4e423 
- Mark entities as removed
@aleksejsbaranovs
Support for ratings & reviews in Storefront App
2646128 
- Reviews and rating metadata callbacks
@aleksejsbaranovs
Support for ratings & reviews in Storefront App
aaf6fd7 
- Review repository
@aleksejsbaranovs
Support for ratings & reviews in Storefront App
d25a4c5 
- Rating metadata repository
@aleksejsbaranovs
Support for ratings & reviews in Storefront App
55b0f40 
- Reviews and ratings events
@aleksejsbaranovs
Support for ratings & reviews in Storefront App
161bbeb 
- Reviews and ratings events
@aleksejsbaranovs
Support for ratings & reviews in Storefront App
79d1543 
- Export reviews w/o rating assigned
@aleksejsbaranovs
Support for ratings & reviews in Storefront App
57f2980 
- Tests fix
@aleksejsbaranovs10 aleksejsbaranovs10 changed the title Story 351 product reviews Support for ratings & reviews in Storefront App Nov 4, 2020
@aleksejsbaranovs10 aleksejsbaranovs10 mentioned this pull request Nov 4, 2020
Closed
7 tasks
@aleksejsbaranovs10 aleksejsbaranovs10 mentioned this pull request Nov 5, 2020
Merged
4 tasks
@aleksejsbaranovs10
Copy link
Contributor Author

@magento run all tests

@aleksejsbaranovs10
Copy link
Contributor Author

@magento run Static Tests, WebAPI Tests

1 similar comment
@aleksejsbaranovs10
Copy link
Contributor Author

@magento run Static Tests, WebAPI Tests

@aleksejsbaranovs10
Copy link
Contributor Author

@magento run WebAPI Tests

@aleksejsbaranovs10 aleksejsbaranovs10 mentioned this pull request Nov 9, 2020
Merged
7 tasks
@aleksejsbaranovs10
Copy link
Contributor Author

@magento run Static Tests, WebAPI Tests

2 similar comments
@aleksejsbaranovs10
Copy link
Contributor Author

@magento run Static Tests, WebAPI Tests

@aleksejsbaranovs10
Copy link
Contributor Author

@magento run Static Tests, WebAPI Tests

@aleksejsbaranovs10
Copy link
Contributor Author

@magento run WebAPI Tests

@aleksejsbaranovs10
Copy link
Contributor Author

@magento run all tests

@aleksejsbaranovs10
Copy link
Contributor Author

@magento run WebAPI Tests

@aleksejsbaranovs10
Copy link
Contributor Author

@magento run Static Tests

@aleksejsbaranovs10
Copy link
Contributor Author

@magento run WebAPI Tests

3 similar comments
@aleksejsbaranovs10
Copy link
Contributor Author

@magento run WebAPI Tests

@aleksejsbaranovs10
Copy link
Contributor Author

@magento run WebAPI Tests

@aleksejsbaranovs10
Copy link
Contributor Author

@magento run WebAPI Tests

@RuslanKostiv1
Copy link
Contributor

@aleksejsbaranovs10 please fix merge conflict

@RuslanKostiv1
Copy link
Contributor

@magento run WebAPI Tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run WebAPI Tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

@magento run all tests

@RuslanKostiv1
Copy link
Contributor

Fix static failures
https://github.com/magento/commerce-data-export/pull/2/checks?check_run_id=1426480652 @aleksejsbaranovs10
WebAPI Tests are fixed now

RuslanKostiv1
RuslanKostiv1 reviewed Nov 20, 2020
View reviewed changes
app/code/Magento/CatalogExport/Model/RatingMetadataRepository.php Outdated
/**
* @inheritdoc
*/
public function get(EntityRequest $request)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return type is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

app/code/Magento/CatalogExportApi/Api/RatingMetadataRepositoryInterface.php Outdated
*
* @throws \InvalidArgumentException
*/
public function get(EntityRequest $request);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return type is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

app/code/Magento/CatalogExportApi/Api/ReviewRepositoryInterface.php Outdated
*
* @throws \InvalidArgumentException
*/
public function get(EntityRequest $request);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return type is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@RuslanKostiv1
Copy link
Contributor

Please fix Static Tests failures
https://github.com/magento/commerce-data-export/pull/2/checks?check_run_id=1426480652

@aleksejsbaranovs10 aleksejsbaranovs10 mentioned this pull request Dec 1, 2020
Merged
6 tasks
@RuslanKostiv1 RuslanKostiv1 mentioned this pull request Dec 1, 2020
Closed
@RuslanKostiv1
Copy link
Contributor

@magento import pr to magento-commerce/commerce-data-export

@magento-engcom-team
Copy link

@RuslanKostiv1 the pull request successfully imported.

@mmansoor-magento mmansoor-magento merged commit 7dd9129 into magento:main Dec 10, 2020
mmansoor-magento pushed a commit that referenced this pull request Jan 6, 2021
@aleksejsbaranovs10
Merge pull request #2 from aleksejsbaranovs10/story-469-gift-cards
bb81929 
Gift cards price notification events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuslanKostiv1 RuslanKostiv1 RuslanKostiv1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for ratings & reviews in Storefront App
5 participants
@aleksejsbaranovs10 @RuslanKostiv1 @magento-engcom-team @mmansoor-magento @aleksejsbaranovs