465 price full sync #21
Conversation
- Price change events
- Price change events
- Base price / special price batch processing
- Events batch processing
- Events batch processing
- Events batch processing
…port into story-443-price-notifications
- Events batch processing
- Improved custom option price notifications - Added/Improved custom option type price notifications
- Events batch processing
- Events batch processing
-Added amqp
- Events batch processing
…port into story-443-price-notifications
-Reworked message formatting for tier prices, customizable prices and normal prices
- Events batch processing
- Price events
- Price events
- Price events
- Static tests fix
- Price events
-Added product price full sync implementation with batching -Temporarily disabled the rest of the prices providers for development
- Integration test fix
…port into story-443-price-notifications
461: Integration test failure (workaround)
| /** | ||
| * Class responsible for indexing product prices and provide price change events | ||
| */ | ||
| class ProductPricesFeedIndexer implements IndexerActionInterface, MviewActionInterface |
There was a problem hiding this comment.
It's better to create a separate model, which will collect price data instead of depending on indexer functionality.
From indexer, we need only the "full reindex" feature.
For partial updates we may use indexer but only for the ability to use mview functionality
-Added separate providers for full reindex -Reorganised class structure to fit requirements
|
@magento run all tests |
-di fix
|
@magento run all tests |
-Code cleanup
|
@magento run all tests |
-Static fixes
-Moved full price synchronisation to cli command, in order to decouple from unnecessary general indexer logic
-Modified cli command to support synchronizing by single price type and moved the logic out of the cli command itself -Added abstract test and 2 tests -Other minor changes
|
@magento run all tests |
|
Unfortunately I didn't finish adding tests in time. I added Abstract test and tests for bundle and simple product prices so these are functioning examples to make the other tests. |
|
@magento import pr to magento-commerce/commerce-data-export |
|
@mslabko the pull request successfully imported. |
Description (*)
Related Pull Requests
Extends and depends on the following pull request:
#20
Fixed Issues (if relevant)
Questions or comments
Code Review Checklist (*)