Skip to content

Update live-edit.ts DOM Text Interpreted As HTML #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Update live-edit.ts DOM Text Interpreted As HTML #883

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c9ed5a2
Update live-edit.ts
Shivam7-1 Jan 8, 2025
7e2b50f
Update-1 live-edit.ts
Shivam7-1 Jan 10, 2025
7e41f5c
Removed use of stripHtml
Shivam7-1 Jan 13, 2025
804d9ef
Merge branch 'develop' into patch-2
engcom-Hotel Jan 15, 2025
a8759cf
Merge branch 'develop' into patch-2
engcom-Hotel Apr 4, 2025
da98e76
Merge branch 'develop' into patch-2
engcom-Hotel Aug 14, 2025
e0abe5e
Merge branch 'develop' into patch-2
engcom-Hotel Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts
View file
Original file line number Diff line number Diff line change
@@ -33,14 +33,13 @@ function stripHtml(html: string) {
* @param {Element} element
*/
function handlePlaceholderClass(element: Element) {
if (stripHtml(element.innerHTML).length === 0) {
element.innerHTML = "";
if (element.textContent.length === 0) {
element.textContent = "";
element.classList.add("placeholder-text");
} else {
element.classList.remove("placeholder-text");
}
}

// Custom Knockout binding for live editing text inputs
ko.bindingHandlers.liveEdit = {