Skip to content

Street lines ignoring blank lines #27847

Closed
@r-martins

Description

@r-martins
Contributor

Preconditions (*)

  1. Magento Open Source 2.3.4 to 2.4.1
  2. Configure Customer street lines to 3 or more lines
  3. No additional module or configuration is required

Steps to reproduce (*)

  1. Go to Customer configuration in admin, and set the number of street lines to 3 or more (customer/address/street_lines)
  2. In the frontend, proceed to checkout and add a new address. When adding a new address in the checkout, leave blank street lines in the middle. I.e: Populate line 1 with Line 1 string, and line 3 with Line 3 string.
  3. After the order is placed and the address is saved, try to edit this address or see this address in the database (table customer_address_entity).

Expected result (*)

  1. It's expected to see the line 1 and 3 populated in the frontend when going to customer's adress book (/customer/address).
  2. It's expected to see the value Line 1⏎⏎Line 3 in the database

Actual result (*)

  1. The value we inserted in the address line 3 is displayed as line 2 when editing the address
  2. In customer_address_entity.street column we see Line 1⏎Line 3.

Note that doesn't happen if you manually insert the address in customer area (instead of inserting it during the checkout).

Screenshot_14_04_20_09_32
magento2playground____www_magento2playground__-magento2playground_customer_address_entity__magento2playground_localhost
Edit_Address

issue-27847

Additional Information

Quote from #27847 (comment)

I don't remember problems in the frontend, except when editing the address.
The main problem is that it breaks integrations that relies on the correct line. For instance, we use line 4 as Neighborhood in many stores in Brazil, but we faced integration issues when it's saved in line 3. It also breaks payments integrations(and payment methods) that requires neighborhood for placing an order. In those cases, registered customers can't place an order with an existing address.
These are just a few cases.

Activity

m2-assistant

m2-assistant commented on Apr 13, 2020

@m2-assistant

Hi @r-martins. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
    Information on your environment
    Steps to reproduce
    Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@r-martins do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
    no

r-martins

r-martins commented on Apr 13, 2020

@r-martins
ContributorAuthor

@magento give me 2.4-develop instance

magento-engcom-team

magento-engcom-team commented on Apr 13, 2020

@magento-engcom-team
Contributor

Hi @r-martins. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team

magento-engcom-team commented on Apr 13, 2020

@magento-engcom-team
Contributor

Hi @r-martins, here is your Magento instance.
Admin access: https://i-27847-2-4-develop.instances.magento-community.engineering/admin_cf28
Login: 215c7447 Password: b4652bc4c4cc
Instance will be terminated in up to 3 hours.

r-martins

r-martins commented on Apr 13, 2020

@r-martins
ContributorAuthor

@magento give me 2.3.4 instance

magento-engcom-team

magento-engcom-team commented on Apr 13, 2020

@magento-engcom-team
Contributor

Hi @r-martins. Thank you for your request. I'm working on Magento 2.3.4 instance for you

magento-engcom-team

magento-engcom-team commented on Apr 13, 2020

@magento-engcom-team
Contributor

Hi @r-martins, here is your Magento instance.
Admin access: https://i-27847-2-3-4.instances.magento-community.engineering/admin_e1fa
Login: f8da86f9 Password: 8287f1b7f570
Instance will be terminated in up to 3 hours.

r-martins

r-martins commented on Apr 14, 2020

@r-martins
ContributorAuthor

I could reproduce the error both in 2.3.4 and 2.4-develop instances when adding address in checkout process.
Edit_Address

added
Reproduced on 2.3.xThe issue has been reproduced on latest 2.3 release
Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch
on Apr 14, 2020
self-assigned this
on Apr 14, 2020
m2-assistant

m2-assistant commented on Apr 14, 2020

@m2-assistant

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

    3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

    4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

    5. Add label Issue: Confirmed once verification is complete.

    6. Make sure that automatic system confirms that report has been added to the backlog.

25 remaining items

r-martins

r-martins commented on Jan 15, 2021

@r-martins
ContributorAuthor

I was able to test the Pull Request #28126 on Magento 2.4.1 and it seems it does fix this issue. I hope someone from Magento could notice the importance of this issue.

r-martins

r-martins commented on Jan 27, 2022

@r-martins
ContributorAuthor

🎂 Happy birthday to this old and persistent bug! I hope someone takes care of you one day.

ZIPITRO

ZIPITRO commented on Mar 17, 2022

@ZIPITRO

Anyone can move this issue to the drawing table please?

engcom-Bravo

engcom-Bravo commented on Jun 26, 2024

@engcom-Bravo
Contributor

Hi @r-martins,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is no more reproducible.Kindly refer the attached video.

Screen.Recording.2024-06-26.at.09.55.08.mov

We are able to to see the line 1 and 3 populated in the frontend when going to customer's adress book

Hence we are closing this issue.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Component: CustomerIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P3May be fixed according to the position in the backlog.Progress: doneReported on 2.3.4Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.Triage: DoneHas been reviewed and prioritized during Triage with Product Managers

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @r-martins@sdzhepa@tna274@ZIPITRO@magento-engcom-team

    Issue actions

      Street lines ignoring blank lines · Issue #27847 · magento/magento2