Skip to content

[Issue] Use MenuCategoryData to generate array in TopMenu plugin to allow extension via plugins #29664

Open
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #28715: Use MenuCategoryData to generate array in TopMenu plugin to allow extension via plugins


Description

Following discussion on Magento Community Engineering Slack instance, it has become clear that the private method Magento\Catalog\Plugin\Block\Topmenu::getCategoryAsArray() should be abstracted to allow extension via plugin (as inheritance (via preference) is to be discouraged). It appears that an existing class provides most of the functionality required. This pull request changes getCategoryAsArray() to use this existing external class (with public method) to allow this data to be augmented via plugin on the latter.

Related Pull Requests

None known

Fixed Issues

None known

Manual testing scenarios

See also discussion on Slack (link above).

  1. Attempt to add an item to output of getCategoryAsArray() from external code (third party extension)

Questions or comments

I have not yet adjusted any tests, however this should not result in any change in functionality.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
    All commits are accompanied by meaningful commit messages
    All new or changed code is covered with unit/integration tests (if applicable)
    All automated tests passed successfully (all builds are green)

Activity

added
Priority: P3May be fixed according to the position in the backlog.
Severity: S3Affects non-critical data or functionality and does not force users to employ a workaround.
on Aug 18, 2020
ghost assigned on Aug 18, 2020
added
Progress: PR CreatedIndicates that Pull Request has been created to fix issue
and removed
Progress: PR CreatedIndicates that Pull Request has been created to fix issue
on Sep 24, 2020

1 remaining item

added
Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
on Mar 7, 2024
m2-assistant

m2-assistant commented on Jul 8, 2024

@m2-assistant
Author

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    5. Add label Issue: Confirmed once verification is complete.
    6. Make sure that automatic system confirms that report has been added to the backlog.
engcom-November

engcom-November commented on Jul 8, 2024

@engcom-November
Contributor

Hello @fredden,

Thank you for the report and collaboration!

Going through the PR changes, this issue can be confirmed.

added
Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmed
Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch
Reported on 2.4.xIndicates original Magento version for the Issue report.
on Jul 8, 2024
github-jira-sync-bot

github-jira-sync-bot commented on Jul 8, 2024

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12341 is successfully created for this GitHub issue.

m2-assistant

m2-assistant commented on Jul 8, 2024

@m2-assistant
Author

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

moved this to Pull Request In Progress in Low Priority Backlogon Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: FrameworkComponent: CatalogIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is not validGate 1 Failed. Automatic verification of issue format is failedPriority: P3May be fixed according to the position in the backlog.Progress: PR in progressReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @fredden@magento-engcom-team@engcom-November@engcom-Dash@github-jira-sync-bot

    Issue actions

      [Issue] Use MenuCategoryData to generate array in TopMenu plugin to allow extension via plugins · Issue #29664 · magento/magento2