Description
This issue is automatically created based on existing pull request: #28715: Use MenuCategoryData to generate array in TopMenu plugin to allow extension via plugins
Description
Following discussion on Magento Community Engineering Slack instance, it has become clear that the private
method Magento\Catalog\Plugin\Block\Topmenu::getCategoryAsArray()
should be abstracted to allow extension via plugin (as inheritance (via preference) is to be discouraged). It appears that an existing class provides most of the functionality required. This pull request changes getCategoryAsArray()
to use this existing external class (with public
method) to allow this data to be augmented via plugin on the latter.
Related Pull Requests
None known
Fixed Issues
None known
Manual testing scenarios
See also discussion on Slack (link above).
- Attempt to add an item to output of
getCategoryAsArray()
from external code (third party extension)
Questions or comments
I have not yet adjusted any tests, however this should not result in any change in functionality.
Contribution checklist (*)
- Pull request has a meaningful description of its purposeAll commits are accompanied by meaningful commit messagesAll new or changed code is covered with unit/integration tests (if applicable)All automated tests passed successfully (all builds are green)
Activity
1 remaining item
m2-assistant commentedon Jul 8, 2024
Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.- If the issue is reproducible on
2.4-develop
branch, please, add the labelReproduced on 2.4.x
.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
Issue: Confirmed
once verification is complete.engcom-November commentedon Jul 8, 2024
Hello @fredden,
Thank you for the report and collaboration!
Going through the PR changes, this issue can be confirmed.
github-jira-sync-bot commentedon Jul 8, 2024
✅ Jira issue https://jira.corp.adobe.com/browse/AC-12341 is successfully created for this GitHub issue.
m2-assistant commentedon Jul 8, 2024
✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.