Skip to content

getFormattedShippingAddress / getFormattedBillingAddress #29209

Closed
@bernd-reindl

Description

@bernd-reindl

Preconditions (*)

  1. M 2.3.5-p1, 2.4-develop
  2. English and German locale

Steps to reproduce (*)

  1. Create an order in english store
  2. Go to order in backend with an german locale (de_DE) set in admin account profile
  3. Resend the order E-Mail

Expected result (*)

  1. The formatted address in the E-Mail should contain an english country name
    image

Actual result (*)

  1. The formatted address in the E-Mail contains a german country name
    image

The problem:
The function \Magento\Sales\Model\Order\Email\Sender\OrderSender::prepareTemplate() is called before \Magento\Email\Model\AbstractTemplate::applyDesignConfig() starts store emulation. So prepareTemplate() uses the locale and config for adminhtml. Not frontend.


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

    • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
    • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
    • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
    • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
    • [ X] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Activity

m2-assistant

m2-assistant commented on Jul 20, 2020

@m2-assistant

Hi @bernd-reindl. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

bernd-reindl

bernd-reindl commented on Jul 21, 2020

@bernd-reindl
Author

@magento give me 2.4-develop instance

magento-engcom-team

magento-engcom-team commented on Jul 21, 2020

@magento-engcom-team
Contributor

Hi @bernd-reindl. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team

magento-engcom-team commented on Jul 21, 2020

@magento-engcom-team
Contributor

Hi @bernd-reindl, here is your Magento instance.
Admin access: https://i-29209-2-4-develop.instances.magento-community.engineering/admin_57e5
Login: 44aaae2a Password: 28ebd1d8e8e8
Instance will be terminated in up to 3 hours.

bernd-reindl

bernd-reindl commented on Jul 21, 2020

@bernd-reindl
Author

@magento-admin unfortunately i didn't receive the order mails in the 2.4-develop instance. So i can't validate the bug in 2.4-dev.

self-assigned this
on Jul 29, 2020
m2-assistant

m2-assistant commented on Jul 29, 2020

@m2-assistant

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

    3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

    4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

    5. Add label Issue: Confirmed once verification is complete.

    6. Make sure that automatic system confirms that report has been added to the backlog.

Repository owner unassigned on Jul 29, 2020

8 remaining items

added
Triage: DoneHas been reviewed and prioritized during Triage with Product Managers
on Aug 4, 2020
stale

stale commented on Jan 29, 2021

@stale

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

magento-engcom-team

magento-engcom-team commented on Feb 12, 2021

@magento-engcom-team
Contributor

Hi @bernd-reindl, @zaximus84.

Thank you for your report and collaboration!

The related internal Jira ticket MC-36269 was closed as Fixed.

The fix will be available with the upcoming 2.4.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Component: EmailComponent: SalesComponent: TranslationFixed in 2.4.xThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P3May be fixed according to the position in the backlog.Progress: doneReported on 2.3.5-p1Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.Triage: DoneHas been reviewed and prioritized during Triage with Product Managersstale issue

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

    Participants

    @bernd-reindl@zaximus84@magento-engcom-team@engcom-Alfa@engcom-Delta

    Issue actions

      getFormattedShippingAddress / getFormattedBillingAddress · Issue #29209 · magento/magento2