Skip to content

[Issue] Make method signature consistent with interface #38501

Open
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #31955: Make method signature consistent with interface


Description

The interface uses $entityTypeCode. This makes psalm fail without a solution if you are overwriting the method:

With $entityType:

ERROR: ParamNameMismatch - app/code/My/Module/Model/EavAttributeManagement.php:39:35 - Argument 1 of Yubico\Catalog\Model\EavAttributeManagement::getAttributes has wrong name $entityType, expecting $entityTypeCode as defined by Magento\Eav\Api\AttributeManagementInterface::getAttributes (see https://psalm.dev/230)
    public function getAttributes($entityType, $attributeSetId)

With $entityTypeCode:

ERROR: ParamNameMismatch - app/code/My/Module/Model/EavAttributeManagement.php:39:35 - Argument 1 of Yubico\Catalog\Model\EavAttributeManagement::getAttributes has wrong name $entityTypeCode, expecting $entityType as defined by Magento\Eav\Model\AttributeManagement::getAttributes (see https://psalm.dev/230)
    public function getAttributes($entityTypeCode, $attributeSetId)

Manual testing scenarios

  1. Create a class that overwrites \Magento\Eav\Model\AttributeManagement::getAttributes();
  2. Run psalm on your file;

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
    All commits are accompanied by meaningful commit messages
    All new or changed code is covered with unit/integration tests (if applicable)
    All automated tests passed successfully (all builds are green)

Activity

added
Priority: P3May be fixed according to the position in the backlog.
Severity: S4Affects aesthetics, professional look and feel, “quality” or “usability”.
on Mar 8, 2024
added
Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
on Mar 11, 2024
m2-assistant

m2-assistant commented on Mar 12, 2024

@m2-assistant
Author

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    5. Add label Issue: Confirmed once verification is complete.
    6. Make sure that automatic system confirms that report has been added to the backlog.
engcom-November

engcom-November commented on Mar 12, 2024

@engcom-November
Contributor

Hello @kassner,

Thank you for the report and collaboration!

Verified this issue on 2.4-develop.
The attribute name in app/code/Magento/Eav/Api/AttributeManagementInterface.php has been changed when overriding in \Magento\Eav\Model\AttributeManagement.
Please take a look at the screenshot:
image

Hence confirming the issue.

Thank you.

added
Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmed
Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch
Reported on 2.4.xIndicates original Magento version for the Issue report.
on Mar 12, 2024
github-jira-sync-bot

github-jira-sync-bot commented on Mar 12, 2024

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11578 is successfully created for this GitHub issue.

m2-assistant

m2-assistant commented on Mar 12, 2024

@m2-assistant
Author

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

moved this to Pull Request In Progress in Low Priority Backlogon Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: FrameworkComponent: EavIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.Progress: PR in progressReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S4Affects aesthetics, professional look and feel, “quality” or “usability”.Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @kassner@engcom-November@engcom-Dash@github-jira-sync-bot

    Issue actions

      [Issue] Make method signature consistent with interface · Issue #38501 · magento/magento2