Open
Description
This issue is automatically created based on existing pull request: #31955: Make method signature consistent with interface
Description
The interface uses $entityTypeCode
. This makes psalm fail without a solution if you are overwriting the method:
With $entityType
:
ERROR: ParamNameMismatch - app/code/My/Module/Model/EavAttributeManagement.php:39:35 - Argument 1 of Yubico\Catalog\Model\EavAttributeManagement::getAttributes has wrong name $entityType, expecting $entityTypeCode as defined by Magento\Eav\Api\AttributeManagementInterface::getAttributes (see https://psalm.dev/230)
public function getAttributes($entityType, $attributeSetId)
With $entityTypeCode
:
ERROR: ParamNameMismatch - app/code/My/Module/Model/EavAttributeManagement.php:39:35 - Argument 1 of Yubico\Catalog\Model\EavAttributeManagement::getAttributes has wrong name $entityTypeCode, expecting $entityType as defined by Magento\Eav\Model\AttributeManagement::getAttributes (see https://psalm.dev/230)
public function getAttributes($entityTypeCode, $attributeSetId)
Manual testing scenarios
- Create a class that overwrites
\Magento\Eav\Model\AttributeManagement::getAttributes()
; - Run psalm on your file;
Contribution checklist (*)
- Pull request has a meaningful description of its purposeAll commits are accompanied by meaningful commit messagesAll new or changed code is covered with unit/integration tests (if applicable)All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Gate 3 Passed. Manual verification of the issue completed. Issue is confirmedMay be fixed according to the position in the backlog.Indicates original Magento version for the Issue report.The issue has been reproduced on latest 2.4-develop branchAffects aesthetics, professional look and feel, “quality” or “usability”.Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Activity
m2-assistant commentedon Mar 12, 2024
Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.- If the issue is reproducible on
2.4-develop
branch, please, add the labelReproduced on 2.4.x
.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
Issue: Confirmed
once verification is complete.engcom-November commentedon Mar 12, 2024
Hello @kassner,
Thank you for the report and collaboration!
Verified this issue on 2.4-develop.

The attribute name in
app/code/Magento/Eav/Api/AttributeManagementInterface.php
has been changed when overriding in\Magento\Eav\Model\AttributeManagement
.Please take a look at the screenshot:
Hence confirming the issue.
Thank you.
github-jira-sync-bot commentedon Mar 12, 2024
✅ Jira issue https://jira.corp.adobe.com/browse/AC-11578 is successfully created for this GitHub issue.
m2-assistant commentedon Mar 12, 2024
✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.