Description
Preconditions (*)
Install any version of Magento
Magento 2.4-develop
Steps to reproduce (*)
Implement code such as
public function __construct(
\Magento\Framework\App\CacheInterface $cache
) {
$this->cache = $cache;
}
public function doSomething($identifier)
{
$cached = $this->cache->load($identifier);
if ($cached !== false) {
}Run a CI tool against the code (in our case Scrutinizer)
Expected result (*)
No errors reported by CI tool. Magento\Framework\App\CacheInterface can return a bool and this is the best way to validate if anything is in the cache (see: https://github.com/colinmollenhour/Cm_Cache_Backend_Redis/blob/1.14.1/Cm/Cache/Backend/Redis.php#L473 / https://github.com/colinmollenhour/Cm_Cache_Backend_Redis/blob/1.14.1/Cm/Cache/Backend/Redis.php#L488)
Actual result (*)
CI tool reports violation as Magento\Framework\App\CacheInterface::load annotation indicates only a string can be returned.
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.
- Severity: S0 - Affects critical data or functionality and leaves users without workaround.Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Milestone
Relationships
Participants
Activity
m2-assistant commentedon Dec 23, 2020
Hi @mpchadwick. Thank you for your report.
To help us process this issue please make sure that you provided the following information:
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
@magento give me 2.4-develop instance- upcoming 2.4.x releaseFor more details, please, review the Magento Contributor Assistant documentation.
Please, add a comment to assign the issue:
@magento I am working on this🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.
🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel
✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel
m2-assistant commentedon Jan 8, 2021
Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the labelIssue: Format is validwill be added to the issue automatically. Please, edit issue description if needed, until labelIssue: Format is validappears.2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add
Issue: Clear Descriptionlabel to the issue by yourself.3. Add
Component: XXXXXlabel(s) to the ticket, indicating the components it may be related to.4. Verify that the issue is reproducible on
2.4-developbranchDetails
- Add the comment@magento give me 2.4-develop instanceto deploy test instance on Magento infrastructure.- If the issue is reproducible on
2.4-developbranch, please, add the labelReproduced on 2.4.x.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
5. Add label
Issue: Confirmedonce verification is complete.6. Make sure that automatic system confirms that report has been added to the backlog.
magento-engcom-team commentedon Jan 8, 2021
✅ Confirmed by @engcom-Delta
Thank you for verifying the issue. Based on the provided information internal tickets
MC-40348were createdIssue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
24 remaining items