Skip to content

[Issue] Fix variable name in catalogsearch #37810

Open
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #33533: Fix variable name in catalogsearch


Fix variable name, the search engine has nothing to do with a default country.
PR Update: I've removed the unneccessary variable. Thanks for the idea @tzyganu ;-)

Description (*)

It's a bit strange and confusing to use a variable called $defaultCountry in the search engine module.
I've renamed removed the variable, there's no change in the behavior/logic of the method.

Fixed Issues (if relevant)

none

Manual testing scenarios (*)

Change Search Engine in the magento admin panel:
Stores > Settings > Configuration > Catalog > Catalog > Catalog Search

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
    All commits are accompanied by meaningful commit messages
    All new or changed code is covered with unit/integration tests (if applicable)
    README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
    All automated tests passed successfully (all builds are green)

Activity

linked a pull request that will close this issue on Jul 28, 2023
added
Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmed
Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch
Reported on 2.4.xIndicates original Magento version for the Issue report.
on Jul 28, 2023
github-jira-sync-bot

github-jira-sync-bot commented on Jul 28, 2023

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9215 is successfully created for this GitHub issue.

m2-assistant

m2-assistant commented on Jul 28, 2023

@m2-assistant
Author

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

moved this to Pull Request In Progress in Low Priority Backlogon Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @avoelkl@engcom-Lima@github-jira-sync-bot

    Issue actions

      [Issue] Fix variable name in catalogsearch · Issue #37810 · magento/magento2