Open
Description
Summary
hash
php native method is used at many places, using sha256
algorithm.
Since we dropped PHP7 support in latest versions of Magento, I suggest to change sha256
for xxh128
which is faster.
See : https://php.watch/versions/8.1/xxHash
Examples
I changed on my environment sha256 to xxh128 only in class RemoteSynchronizedCache
class, here are the results :
Before : 33.4ms for hash
execution (called 162 times)
After : less than 1ms for same number of calls
Proposed solution
No response
Release note
No response
Triage and priority
- Severity: S0 - Affects critical data or functionality and leaves users without workaround.Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Pull Request in Progress
Activity
m2-assistant commentedon Apr 27, 2023
Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release@magento I am working on this
Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
m2-assistant commentedon May 15, 2023
Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.- If the issue is reproducible on
2.4-develop
branch, please, add the labelReproduced on 2.4.x
.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
Issue: Confirmed
once verification is complete.engcom-November commentedon May 15, 2023
Hi @Nuranto ,
Thank you for reporting and collaboration. Currently Adobe commerce supports SHA256 but not xxh128 as per Magento documentation however this is a good feature to have and hence considering this as Feature request.
Thank you.
Nuranto commentedon May 17, 2023
Thanks @engcom-November,
However note that this does not concern password hashing (or not only). sha256 hash are used in many other places (cf. given example of RemoteSynchronizedCache).
1 remaining item