Skip to content

Database tables with primary column having signed instead of unsigned definition which is loss of usable values #38585

Open
@kanevbg

Description

@kanevbg

Preconditions and environment

  • Magento develop branch

Steps to reproduce

There is nothing to reproduce, it's a theoretical, architectural problem.

Expected result

Not applicable.

Actual result

Not applicable.

Additional information

Table catalog_product_entity_text has value_id primary column defined as signed int. However the system never stores zero or negative ID in that table.
image.

This means we have 50% usable values of what the underlining database storage may store in practice for the data produced by the application. I have not found a single reason for that column being signed instead of unsigned. Please checkout.

This is applicable to the following tables:

  • catalog_product_entity_datetime
  • catalog_product_entity_decimal
  • catalog_product_entity_int
  • catalog_product_entity_text
  • catalog_product_entity_varchar
  • catalog_product_entity_gallery
  • catalog_category_entity_decimal
  • catalog_category_entity_int
  • catalog_category_entity_text
  • catalog_category_entity_varchar
  • catalog_product_entity_tier_price
  • customer_address_entity_decimal
  • customer_address_entity_int
  • customer_address_entity_text
  • customer_address_entity_varchar
  • customer_entity_datetime
  • customer_entity_decimal
  • customer_entity_int
  • customer_entity_text
  • customer_entity_varchar
  • eav_entity_datetime
  • eav_entity_decimal
  • eav_entity_int
  • eav_entity_text
  • eav_entity_varchar
  • weee_tax

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
    Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
    Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
    Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
    Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Activity

m2-assistant

m2-assistant commented on Apr 6, 2024

@m2-assistant

Hi @kanevbg. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

changed the title [-]catalog_product_entity_X tables with primary value_id column is signed instead of unsigned which is loss of usable values[/-] [+]catalog_product_entity_X tables with primary column having signed instead of unsigned definition which is loss of usable values[/+] on Apr 6, 2024
changed the title [-]catalog_product_entity_X tables with primary column having signed instead of unsigned definition which is loss of usable values[/-] [+]Database tables with primary column having signed instead of unsigned definition which is loss of usable values[/+] on Apr 6, 2024
faizanps

faizanps commented on Apr 6, 2024

@faizanps

@magento give me 2.4-develop instance

magento-deployment-service

magento-deployment-service commented on Apr 6, 2024

@magento-deployment-service

Hi @faizanps. Thank you for your request. I'm working on Magento instance for you.

kanevbg

kanevbg commented on Apr 6, 2024

@kanevbg
Author

@Bashev адаш така е нали 😄

faizanps

faizanps commented on Apr 7, 2024

@faizanps

@magento give me 2.4-develop instance

magento-deployment-service

magento-deployment-service commented on Apr 7, 2024

@magento-deployment-service

Hi @faizanps. Thank you for your request. I'm working on Magento instance for you.

self-assigned this
on Apr 7, 2024
m2-assistant

m2-assistant commented on Apr 7, 2024

@m2-assistant

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

engcom-Dash

engcom-Dash commented on Apr 10, 2024

@engcom-Dash
Contributor

Hi @kanevbg

Thanks for reporting and collaboration.

Verified the issue in magento 2.4 dev instance. The issue is reproducable.

Database tables with primary column having signed instead of unsigned definition. Hence, confirming the issue.

Please refer the attached screenshots.

Screenshot 2024-04-10 at 7 09 02 PM

20 remaining items

moved this to Pull Request In Progress in Low Priority Backlogon Aug 19, 2024
added 3 commits that reference this issue on Sep 14, 2024

magento#38585: Database tables with primary column having signed inst…

magento#38585: Database tables with primary column having signed inst…

magento#38585: Database tables with primary column having signed inst…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Area: AccountComponent: DBIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.Progress: PR in progressReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @kanevbg@faizanps@engcom-Hotel@engcom-Dash@github-jira-sync-bot

    Issue actions

      Database tables with primary column having signed instead of unsigned definition which is loss of usable values · Issue #38585 · magento/magento2