Open
Description
This issue is automatically created based on existing pull request: #39571: [Feature request] Add some functions in Magento\Checkout\Model\Session
Description (*)
This PR add some functions in Magento\Checkout\Model\Session
with phpdoc (method tag) :
- getLastOrderId
- setLastOrderId
- getLastRealOrderId
- setLastRealOrderId
- getLastOrderStatus
- setLastOrderStatus
- getLastQuoteId
- setLastQuoteId
- getLastSuccessQuoteId
- setLastSuccessQuoteId
Adding these methods allows better support for phpstan. Today, with PHPSTAN is very complicated to setup the project with level 5 or higher :(
Related Pull Requests
None
Fixed Issues (if relevant)
None
Manual testing scenarios (*)
Setup PHPSTAN with level 5 or higher and run check.
Questions or comments
The quality of Magento code needs to be improved so that it is easier to use the code quality tools (phpstan, rector, ...) ❤️
Contribution checklist (*)
- Pull request has a meaningful description of its purposeAll commits are accompanied by meaningful commit messagesAll new or changed code is covered with unit/integration tests (if applicable)README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an updateAll automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Type
Projects
Status
Ready for Grooming
Activity
m2-assistant commentedon Jan 28, 2025
Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branchDetails
- If the issue is reproducible on2.4-develop
branch, please, add the labelReproduced on 2.4.x
.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
Issue: Confirmed
once verification is complete.engcom-Bravo commentedon Jan 29, 2025
Hi @dimitriBouteille,
Thanks for your reporting and collaboration.
We are marking this as Feature Request as an improvement to proceed further.
Thanks.