Skip to content

GraphQl Custom Attributes Options output need optimization #39613

Open
@zakdma

Description

@zakdma
Contributor

Class \Magento\EavGraphQl\Model\Output\Value\Options\GetCustomSelectedOptionAttributes is not optimized for attributes with huge amounts of options (> 10000).
Request like this take too much time to retrieve such custom attributes selected values

query {
    products(
      filter: { category_id: { eq: "2"}}
    ) {
        total_count
        items {
            name
            sku
            custom_attributesV2(filters: {used_in_product_listing: true}) {
              items {
                code
                label
                ... on AttributeValue {
                      value
                    }
                ... on AttributeSelectedOptions {
                      selected_options {
                        label
                        value
                      }
                    }
              }
            }
        }
    }
 }

I suggest to optimize it.
The acceleration was from 3 to 4 times for my project.

Activity

m2-assistant

m2-assistant commented on Feb 10, 2025

@m2-assistant

Hi @zakdma. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

zakdma

zakdma commented on Feb 10, 2025

@zakdma
ContributorAuthor

@magento I am working on this

m2-assistant

m2-assistant commented on Feb 10, 2025

@m2-assistant

Hi @zakdma! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

zakdma

zakdma commented on Feb 10, 2025

@zakdma
ContributorAuthor

@magento add to contributors team

m2-assistant

m2-assistant commented on Feb 10, 2025

@m2-assistant

Hi @zakdma! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

zakdma

zakdma commented on Feb 10, 2025

@zakdma
ContributorAuthor

@magento I am working on this

self-assigned this
on Feb 10, 2025
m2-assistant

m2-assistant commented on Feb 10, 2025

@m2-assistant

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    5. Add label Issue: Confirmed once verification is complete.
    6. Make sure that automatic system confirms that report has been added to the backlog.

19 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: CatalogComponent: AttributesIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.Reported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @zakdma@engcom-Bravo@engcom-Hotel@github-jira-sync-bot

    Issue actions

      GraphQl Custom Attributes Options output need optimization · Issue #39613 · magento/magento2