Open
Description
Preconditions and environment
- Magento version: 2.4-develop
Steps to reproduce
- Open the integration test
dev/tests/integration/testsuite/Magento/Eav/Setup/EavSetupTest.php
- Append a new test at the end of the file, which should definitely succeed. For example this one:
public function testAddAttributeAfterInvalidAttributeCodesWereTriedToBeAdded(): void
{
$attributeData = $this->getAttributeData();
$this->eavSetup->addAttribute(\Magento\Catalog\Model\Product::ENTITY, 'test_123', $attributeData);
}
- Now, execute all tests in the file (
cd dev/tests/integration && ../../../vendor/bin/phpunit --filter EavSetupTest
)
Expected result
All tests should be completed successfully.
Actual result
Our simple test fails, although it should not. The following message is outputted:
There was 1 error:
- Magento\Eav\Setup\EavSetupTest::testAddAttributeAfterInvalidAttributeCodesWereTriedToBeAdded
Magento\Framework\Exception\LocalizedException: An attribute code must not be less than 1 and more than 60 characters.\nAn attribute code must not be less than 1 and more than 60 characters.\nAn attribute code must not be less than 1 and more than 60 characters.\nAn attribute code must not be less than 1 and more than 60 characters.\nAttribute code "1first_character_is_not_letter" is invalid. Please use only letters (a-z or A-Z), numbers (0-9) or underscore () in this field, and the first character should be a letter.\nAttribute code "attribute.with.dots" is invalid. Please use only letters (a-z or A-Z), numbers (0-9) or underscore () in this field, and the first character should be a letter.
The reason is that during the previous tests, which tested to add attributes with invalid codes, the Magento\Eav\Model\Validator\Attribute\Code
added error messages to its internal array, which are never resetted. That's why subsequent tests, which try to add attributes, will fail.
Additional information
No response
Release note
No response
Triage and priority
- Severity: S0 - Affects critical data or functionality and leaves users without workaround.Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Metadata
Metadata
Assignees
Labels
Gate 3 Passed. Manual verification of the issue completed. Issue is confirmedA defect with this priority could have functionality issues which are not to expectations.Indicates original Magento version for the Issue report.The issue has been reproduced on latest 2.4-develop branchIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
Type
Projects
Status
Ready for Development
Activity
Added app isolation attribute to tests in EavSetupTest
m2-assistant commentedon Feb 12, 2025
Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branchDetails
- If the issue is reproducible on2.4-develop
branch, please, add the labelReproduced on 2.4.x
.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
Issue: Confirmed
once verification is complete.engcom-Hotel commentedon Feb 12, 2025
Hello @stollr,
Thanks for the report and collaboration!
We have tried to reproduce the issue in the latest 2.4-develop branch and the issue is reproducible for us with the mentioned steps in the main description.
Please refer to the below screenshot for reference:
Hence confirming the issue.
Thanks
github-jira-sync-bot commentedon Feb 12, 2025
✅ Jira issue https://jira.corp.adobe.com/browse/AC-13910 is successfully created for this GitHub issue.
m2-assistant commentedon Feb 12, 2025
✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
7 remaining items