Skip to content

Message queue topology is not considered in setup:db:status check #38225

Open
@mfickers

Description

@mfickers
Contributor

Preconditions and environment

  • Magento 2.4.6-p3
  • RabbitMQ configured

Steps to reproduce

  1. Run setup:upgrade to make sure db schema and data patches are up to date
  2. Add a new binding inside a queue_topology.xml file
  3. Run setup:db:status

Expected result

  • Command will return exit code 2
  • User is informed that setup:upgrade is needed

Actual result

  • Command returns exit code 0
  • Output is "All modules are up to date"

Additional information

Magento_Amqp module contains a recurring setup script that will upgrade the queue topology: \Magento\Amqp\Setup\Recurring. Updates to the topology configuration will only take effect when setup:upgrade is run.

The command setup:db:status should inform the user if a setup:upgrade is needed or not. It is used by deployment scripts like the Magento 2 recipe of Deployer. If the command returns exit code 0, then setup:upgrade is skipped during deployment and the message queue topology might be out of date.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
    Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
    Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
    Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
    Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Activity

m2-assistant

m2-assistant commented on Nov 27, 2023

@m2-assistant

Hi @mfickers. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

added
Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
Reported on 2.4.6-p3Indicates original Magento version for the Issue report.
on Nov 28, 2023
m2-assistant

m2-assistant commented on Dec 4, 2023

@m2-assistant

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    5. Add label Issue: Confirmed once verification is complete.
    6. Make sure that automatic system confirms that report has been added to the backlog.
engcom-November

engcom-November commented on Dec 5, 2023

@engcom-November
Contributor

Hello @mfickers,

Thank you for the report and collaboration!

We were able to verify this issue on 2.4-develop.
As mentioned in the steps we added a new binding inside queue_topology.xml, and ran the setup:db:status command.
The topology binding was not considered and we got the the exit code 0 with the message "All modules are up to date".

Hence confirming this issue.

Thank you.

github-jira-sync-bot

github-jira-sync-bot commented on Dec 5, 2023

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10641 is successfully created for this GitHub issue.

m2-assistant

m2-assistant commented on Dec 5, 2023

@m2-assistant

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

11 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: FrameworkComponent: SetupIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: ready for devReported on 2.4.6-p3Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @Vigneshmuthusamy@mfickers@engcom-Hotel@engcom-November@engcom-Dash

    Issue actions

      Message queue topology is not considered in `setup:db:status` check · Issue #38225 · magento/magento2