Skip to content

[GraphQl] Route query infinite loop #39707

Open
@rybkinevg

Description

@rybkinevg

Preconditions and environment

  • Magento version: 2.4.7-p4

Steps to reproduce

  1. Go to Magento Admin -> Marketing -> SEO & Search -> URL Rewrites
  2. Create a new URL rewrite via Add URL Rewrite with following values:
    • Create URL Rewrite = Custom
    • Request Path = test
    • Target Path = test
  3. Send the following GraphQl query:
{
  route(url: "/test") {
    relative_url
  }
}

Expected result

{
  "errors": [
    {
      "message": "No such entity found with matching URL key: test",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "route"
      ],
      "extensions": {
        "category": "graphql-no-such-entity"
      }
    }
  ],
  "data": {
    "route": null
  }
}

Actual result

The request have been cycled in the infinite loop, and some day will fall with timeout

Additional information

The example above is synthetic, but custom URL rewrite entity types will be affected by this issue.

For example, if we have the Blog module with Post entity, and we are not going to show posts via Magento frontend (so we do not have the frontend controllers) we will fetch them via GraphQl queries and show on the custom frontend.

We will create the custom URL rewrite entity type and resolver for it:

enum UrlRewriteEntityTypeEnum {
    BLOG_POST
}

Also we will create the URL rewrite entry for post with the following values:

  • Create URL Rewrite = Custom
  • Request Path = blog/some-post-title
  • Target Path = blog/some-post-title

When frontend will query the route it will fall with timeout.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
    Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
    Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
    Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
    Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Activity

m2-assistant

m2-assistant commented on Mar 5, 2025

@m2-assistant

Hi @rybkinevg. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

linked a pull request that will close this issue on Mar 5, 2025
self-assigned this
on Mar 5, 2025
m2-assistant

m2-assistant commented on Mar 5, 2025

@m2-assistant

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    5. Add label Issue: Confirmed once verification is complete.
    6. Make sure that automatic system confirms that report has been added to the backlog.
engcom-Bravo

engcom-Bravo commented on Mar 6, 2025

@engcom-Bravo
Contributor

Hi @rybkinevg,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.kindly refer the screenshot.

Image

We are getting response as null.could you please let us know if we are missing anything and please try to reproduce the issue in Latest 2.4-develop instance.

Thanks.

moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Boardon Mar 6, 2025
rybkinevg

rybkinevg commented on Mar 6, 2025

@rybkinevg
Author

Hi, @engcom-Bravo !

Thanks for your reply, but I am confirming that the issue is reproducible in 2.4-develop, I will describe steps which I done:

  1. I installed the fresh Magento instance from 2.4-develop branch
  2. Passed basic installation steps (DB setup, install command, admin setup)
  3. Created a new URL Rewrite with following values:
  • Create URL Rewrite = Custom
  • Request Path = test
  • Target Path = test
Image Image
  1. I configured the request timeout to 1 min (60000 ms), screenshot taken from Bruno HTTP client:
Image
  1. I send the following request and waited for 1 min:
{
  route(url: "/test") {
    relative_url
  }
}
Image
  1. I added some debug info to the app/code/Magento/UrlRewriteGraphQl/Model/Resolver/AbstractEntityUrl.php::findFinalUrl:
    private function findFinalUrl(UrlRewrite $urlRewrite): UrlRewrite
    {
        $count = 0;

        do {
            $nextUrlRewrite = $this->findUrlFromRequestPath(
                $urlRewrite->getTargetPath(),
                (int) $urlRewrite->getStoreId()
            );
            if ($nextUrlRewrite) {
                $urlRewrite = $nextUrlRewrite;
            }

            if ($count > 30) {
                die('I am in an endless loop');
            }

            $count++;
        } while ($nextUrlRewrite);

        return $urlRewrite;
    }
  1. I resend the route request:
Image

UPD I also double checked that the route query resolver in 2.4-develop branch still extends from the AbstractEntityUrl class and calling the parent::resolve() method which has the findFinalUrl method where the problem with endless loop appears

gabrieldagama

gabrieldagama commented on Mar 14, 2025

@gabrieldagama
Contributor

@magento give me a 2.4-develop instance

engcom-Bravo

engcom-Bravo commented on Mar 19, 2025

@engcom-Bravo
Contributor

Hi @rybkinevg,

Thanks for your update.

We have tried to reproduce the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Image

Getting response as error timedout.

Hence Confirming the issue.

Thanks.

added
Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmed
and removed
Issue: needs updateAdditional information is require, waiting for response
on Mar 19, 2025

14 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: ContentComponent: UrlRewriteIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Reported on 2.4.7-p4Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @gabrieldagama@rybkinevg@engcom-Bravo@github-jira-sync-bot

    Issue actions

      [GraphQl] Route query infinite loop · Issue #39707 · magento/magento2