Closed
Description
Summary
Following this documentation in order to register a custom shipping rate validator, I found out that shipping-rates-validator.js::validateAddressData would never execute the registered validator as long as the default validator returns true.
This is because shipping-rates-validator.js registers a default-validator and when it runs the validation it considers the rates as valid when at least on of the registered validators returned true.
This is problematic, as the custom validator would not even run when the default validator returns true.
Examples
N/A
Proposed solution
Change this function validateAddressData in module-checkout/view/frontend/web/js/model/shipping-rates-validator.js
From:
validateAddressData: function (address) {
return validators.some(function (validator) {
return validator.validate(address);
});
},
To:
validateAddressData: function (address) {
return validators.forEach(function (validator) {
return validator.validate(address);
});
},
```
### Release note
_No response_
### Triage and priority
- [ ] Severity: **S0** _- Affects critical data or functionality and leaves users without workaround._
- [ ] Severity: **S1** _- Affects critical data or functionality and forces users to employ a workaround._
- [X] Severity: **S2** _- Affects non-critical data or functionality and forces users to employ a workaround._
- [ ] Severity: **S3** _- Affects non-critical data or functionality and does not force users to employ a workaround._
- [ ] Severity: **S4** _- Affects aesthetics, professional look and feel, “quality” or “usability”._
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
Participants
Activity
m2-assistant commentedon Aug 13, 2024
Hi @kooliahmd. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance- upcoming 2.4.x release@magento I am working on thisJoin Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
m2-assistant commentedon Aug 26, 2024
Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
Area: XXXXXlabel to the ticket, indicating the functional areas it may be related to.2.4-developbranchDetails
- Add the comment@magento give me 2.4-develop instanceto deploy test instance on Magento infrastructure.- If the issue is reproducible on
2.4-developbranch, please, add the labelReproduced on 2.4.x.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
Issue: Confirmedonce verification is complete.engcom-Hotel commentedon Aug 26, 2024
Hello @kooliahmd,
Thanks for the report and collaboration!
We have tried to reproduce the issue in the latest 2.4-develop branch. In order to reproduce it we have made a custom module as follows:
https://github.com/engcom-Hotel/magento2/tree/issue39039/app/code/Magz/Issue39039
But we are unable to reproduce it, can you please let us know if we missed anything?
Thanks
engcom-Hotel commentedon Sep 10, 2024
Dear @kooliahmd,
We've observed that there haven't been any updates on this issue for quite some time. Therefore, we assume it's been resolved and will close it. Feel free to open a new ticket or reopen this one if you require further assistance.
Regards