[Issue] Use constructor property promotion in module Vault graph Ql

[m2-assistant]

This issue is automatically created based on existing pull request: #36996: Use constructor property promotion in module Vault graph Ql

---

Description (*)

Replace allmost all properties with constructor property promotion in module version: https://stitcher.io/blog/constructor-promotion-in-php-8

• Readable code
• Make Magento less complex by removing properties which take up a lot of lines.
• Imported all classes to make code more readable. I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now :).

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[engcom-Dash]

Hello @leonhelmus,

Thanks for the report and collaboration!

We have looked into the attached PR of this issue and found that the PR is related to making improvements in the Magento codebase using constructor property promotion.

Hence confirming this issue.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14616 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[engcom-Bravo]

As per this comment #36996 (comment) closing this issue.