Closed
Description
Preconditions and environment
- Magento version 2.4.7
Steps to reproduce
- Try to update status from admin order page view
Expected result
Status updated
Actual result
Status not updated
Additional information
I don't understand this change introduced in 2.4.7 :
#36562
private function getOrderStatus(string $orderStatus, string $historyStatus): string
{
return ($orderStatus === Order::STATE_PROCESSING || $orderStatus === Order::STATUS_FRAUD) ? $historyStatus
: $orderStatus;
}
Why would we be able to change status only if current status is processing or fraud ? (Also, Order::STATE_PROCESSING
instead of Order::STATUS_PROCESSING
)
If I understand correctly the issue #36562, the fix should be something like this instead :
private function getOrderStatus(OrderInterface $order, string $historyStatus): string
{
$statuses = $this->orderConfig->getStateStatuses($order->getState());
if (!in_array($status, array_keys($statuses))) {
return $order->getStatus();
}
return $historyStatus;
}
Or am I missing something ?
Release note
No response
Triage and priority
- Severity: S0 - Affects critical data or functionality and leaves users without workaround.Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Activity
m2-assistant commentedon Apr 25, 2024
Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release@magento I am working on this
Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
m2-assistant commentedon Apr 25, 2024
Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.- If the issue is reproducible on
2.4-develop
branch, please, add the labelReproduced on 2.4.x
.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
Issue: Confirmed
once verification is complete.[-]Order status update[/-][+][Issue] Cannot update Order status in 2.4.7[/+]m2-assistant commentedon Apr 25, 2024
Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.- If the issue is reproducible on
2.4-develop
branch, please, add the labelReproduced on 2.4.x
.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
engcom-Dash commentedon Apr 25, 2024
@magento give me 2.4-develop instance
magento#38659 - Fix order status update
magento-deployment-service commentedon Apr 25, 2024
Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.
magento-deployment-service commentedon Apr 25, 2024
Hi @engcom-Dash, here is your Magento Instance: https://fe74e6b08484c0858eb929e57e74a885.instances-prod.magento-community.engineering
Admin access: https://fe74e6b08484c0858eb929e57e74a885.instances-prod.magento-community.engineering/admin_f188
Login: 64dd48de
Password: 68a200a92f49
80 remaining items