-
Notifications
You must be signed in to change notification settings - Fork 9.4k
logging-in in order to checkout when guest checkout is disabled #6015 #24794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
logging-in in order to checkout when guest checkout is disabled #6015 #24794
Conversation
Hi @ivan-koliadynskyy. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
I have feeling that error on Functional Tests build appear because testing flow expect user will be not redirect to checkout page after login / sign up and will need to navigate to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ivan-koliadynskyy. Thanks for collaboration. Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.
@VladimirZaets , thank you about feedback. According to issue description:
And I see that there is additional step to click checkout link after login according to Functional Test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check information related to this change from comment #24794 (comment)
…checkout page right after registration.
…ter click checkout and login instead of cart page like it was before.
Idea of this fix is redirect user to checkout page when user click checkout and made login with dialog. |
…direct-to-checkout-6015
… guest-login-redirect-to-checkout-6015
… guest-login-redirect-to-checkout-6015
I will take care of test coverage. |
Hi, @ivan-koliadynskyy. Failed functional tests not related to the changes in this PR |
@magento run all tests |
Hi @VladimirZaets , @paliarush , @DrewML |
Hi @VladimirZaets.
In the file
was be deleted the second click to 'Proceed To Checkout'. This is exactly the goal that PR has achieved. |
@magento run all tests |
@engcom-Echo can you please take a look at failed tests? |
… guest-login-redirect-to-checkout-6015
… guest-login-redirect-to-checkout-6015
… guest-login-redirect-to-checkout-6015
@magento run all tests |
… guest-login-redirect-to-checkout-6015
@magento run all tests |
Failed functional tests not related to the changes in this PR |
Hello, @ivanko-dev - thanks for your efforts contributing to Magento and your work on this pull request! It's one of the oldest pull requests still open on the Magento 2 repository, and I can see it was originally authored against Magento 2.3. I'm wondering if you are aware of this is still an issue in Magento 2.4, or if you have the time and interest in helping work to get this pull request moved closer to being merged or closed? Let me know how I can help. Thanks! |
#6015
Description (*)
Issue appear in case if "login_redirect" value in cookie missing. This case was reproduced with login using dialog opened by click "Proceed to Checkout" on cart page.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)