GH-26597: Also calculate tax discount compensation amount when prices are configured excl. tax #26598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue raised here: #26597
See: \Magento\Tax\Model\Calculation\AbstractAggregateCalculator::calculateWithTaxInPrice and notice that in this scenario, the calculator does the correct thing for computing compensation value:
$discountTaxCompensationAmount = $rowTax - $rowTaxAfterDiscount;
Meanwhile in: \Magento\Tax\Model\Calculation\AbstractAggregateCalculator::calculateWithTaxNotInPrice the calculation is missing. Tax discount compensation should be calculated regardless of whether catalog prices were provided incl vs excl tax.