Skip to content

Added Add to cart notification for related Products #27245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from
Open

Added Add to cart notification for related Products #27245

wants to merge 3 commits into from

Conversation

niravkrish
Copy link
Contributor

@niravkrish niravkrish commented Mar 11, 2020 •
edited by sdzhepa
Loading

Preconditions (*)

On a product view, when selecting a related product and adding it to the cart with the current product, the notification doesn't reflect the two product being added, it says:

You added CURRENT PRODUCT NAME to your shopping cart.

However 2 products (the current product and the related product) are added to the cart where added. It should read:

You added CURRENT PRODUCT NAME and RELATED PRODUCT NAME to your shopping cart.

Steps to reproduce (*)

  1. Go to product page (choose a product which has a related product)
  2. Select a related product
  3. Click "Add to cart"

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Add to cart notification for related products #27164: Add to cart notification for related products

Manual testing scenarios (*)

  1. Manual Testing

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 11, 2020

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@niravkrish niravkrish requested a review from mageprince March 11, 2020 14:06
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels May 4, 2020
@m2-community-project m2-community-project bot added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mageprince mageprince

Assignees
No one assigned
Labels
Component: Checkout Priority: P3 May be fixed according to the position in the backlog. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: pending review Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add to cart notification for related products
2 participants
@niravkrish @magento-engcom-team