Skip to content

Issue #35612 Magento\SalesGraphQl\Model\OrderItem\DataProvider uses non-contract methods on OrderItemInterface #35850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

artskirk
Copy link

@artskirk artskirk commented Aug 1, 2022

Description (*)

I have added getStatus method to the Magento\Sales\Api\Data\OrderItemInterface .
Open vendor/magento/module-sales-graph-ql/Model/OrderItem/DataProvider.php and goto line 140. Here a implementation specific method (getStatus) is called on an interface. This method does not exists in the interface.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Magento\SalesGraphQl\Model\OrderItem\DataProvider uses non-contract methods on OrderItemInterface #35612

Manual testing scenarios (*)

  1. Update the module-sales-graph-ql\Model\Resolver\OrderItems.php:55 with the following code:
        $orderId = 10;
        $objectManager = Bootstrap::create(BP, $_SERVER)->getObjectManager();
        /** @var \Magento\Sales\Api\OrderRepositoryInterface $orderRepository */
        $orderRepository = $objectManager->get(\Magento\Sales\Api\OrderRepositoryInterface::class);
        $value['model'] = $orderRepository->get($orderId);
  1. Use the following GraphQl query to retrieve the order items:
{
  customerOrders {    
    items {
      increment_id
      status         
      order_number
      id      
      created_at
      items {
          id
          status
      }     
    }
  }
}
  1. Ensure there is no issues occurring with $orderItem->getStatus() method in module-sales-graph-ql\Model\OrderItem\DataProvider.php

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2022

Hi @artskirk. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Progress: pending review labels Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: review
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

Magento\SalesGraphQl\Model\OrderItem\DataProvider uses non-contract methods on OrderItemInterface
3 participants