Fix Url Rewrite not generated for stores that have different url key and adds the deprecated message to CategoryBasedProductRewriteGenerator class

app/code/Magento/Catalog/Test/Mftf/Test/AdminProductCustomURLKeyPreservedWhenAssignedToCategoryWithoutCustomURLKeyTest.xml

@@ -101,7 +101,7 @@
         <!-- Open second product  -->
         <click selector="{{StorefrontCategoryProductSection.ProductTitleByName($createSimpleProductSecond.name$)}}" stepKey="openSecondProduct"/>
         <waitForPageLoad time="30" stepKey="waitForSecondProduct"/>
-        <seeInCurrentUrl url="{$simpleProductSecondNameLower}.html" stepKey="checkSecondSimpleProductUrlKey"/>
+        <seeInCurrentUrl url="u2.html" stepKey="checkSecondSimpleProductUrlKey"/>
 
         <actionGroup ref="StorefrontSwitchStoreViewActionGroup" stepKey="switchToCustomStoreView">
             <argument name="storeView" value="storeViewData"/>

app/code/Magento/CatalogUrlRewrite/Model/CategoryBasedProductRewriteGenerator.php

@@ -11,8 +11,9 @@
 
 /**
  * Class ProductUrlRewriteGenerator
- * @package Magento\CatalogUrlRewrite\Model
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @deprecated 101.0.0 please use \Magento\CatalogUrlRewrite\Model\CategoryProductUrlPathGenerator instead.
+ * @see https://github.com/magento/magento2/commit/c7d6324fe84766ddd9ab9710f19b5923fcbac09a
  */
 class CategoryBasedProductRewriteGenerator
 {

app/code/Magento/CatalogUrlRewrite/Model/ProductUrlRewriteGenerator.php

@@ -6,12 +6,12 @@
 namespace Magento\CatalogUrlRewrite\Model;
 
 use Magento\Catalog\Model\Product;
+use Magento\Catalog\Model\Product\Visibility;
 use Magento\CatalogUrlRewrite\Model\Product\CanonicalUrlRewriteGenerator;
 use Magento\CatalogUrlRewrite\Model\Product\CategoriesUrlRewriteGenerator;
 use Magento\CatalogUrlRewrite\Model\Product\CurrentUrlRewritesRegenerator;
 use Magento\CatalogUrlRewrite\Service\V1\StoreViewService;
 use Magento\Framework\App\ObjectManager;
-use Magento\Catalog\Model\Product\Visibility;
 use Magento\Store\Model\Store;
 use Magento\Store\Model\StoreManagerInterface;
 
@@ -28,6 +28,7 @@ class ProductUrlRewriteGenerator
     /**
      * @deprecated 100.1.0
      * @see not used
+     * @see https://github.com/magento/magento2/commit/6729b6e01368248abc33300208eb292c95050203
      * @var \Magento\CatalogUrlRewrite\Service\V1\StoreViewService
      */
     protected $storeViewService;
@@ -36,47 +37,55 @@ class ProductUrlRewriteGenerator
      * @var \Magento\Catalog\Model\Product
      * @see not used
      * @deprecated 100.1.0
+     * @see https://github.com/magento/magento2/commit/6729b6e01368248abc33300208eb292c95050203
      */
     protected $product;
 
     /**
      * @deprecated 100.1.0
      * @see not used
+     * @see https://github.com/magento/magento2/commit/6729b6e01368248abc33300208eb292c95050203
      * @var \Magento\CatalogUrlRewrite\Model\Product\CurrentUrlRewritesRegenerator
      */
     protected $currentUrlRewritesRegenerator;
 
     /**
      * @deprecated 100.1.0
      * @see not used
+     * @see https://github.com/magento/magento2/commit/6729b6e01368248abc33300208eb292c95050203
      * @var \Magento\CatalogUrlRewrite\Model\Product\CategoriesUrlRewriteGenerator
      */
     protected $categoriesUrlRewriteGenerator;
 
     /**
      * @deprecated 100.1.0
      * @see not used
+     * @see https://github.com/magento/magento2/commit/6729b6e01368248abc33300208eb292c95050203
      * @var \Magento\CatalogUrlRewrite\Model\Product\CanonicalUrlRewriteGenerator
      */
     protected $canonicalUrlRewriteGenerator;
 
     /**
      * @deprecated 100.1.0
      * @see not used
+     * @see https://github.com/magento/magento2/commit/6729b6e01368248abc33300208eb292c95050203
      * @var \Magento\CatalogUrlRewrite\Model\ObjectRegistryFactory
      */
     protected $objectRegistryFactory;
 
     /**
      * @deprecated 100.1.0
      * @see not used
+     * @see https://github.com/magento/magento2/commit/6729b6e01368248abc33300208eb292c95050203
      * @var \Magento\CatalogUrlRewrite\Model\ObjectRegistry
      */
     protected $productCategories;
 
     /**
      * @deprecated 100.1.0
+     * @var \Magento\Store\Model\StoreManagerInterface
      * @see not used
+     * @see https://github.com/magento/magento2/commit/6729b6e01368248abc33300208eb292c95050203
      * @var StoreManagerInterface
      */
     protected $storeManager;
@@ -123,6 +132,7 @@ public function __construct(
      *
      * @deprecated 100.1.4
      * @see not used
+     * @see https://github.com/magento/magento2/commit/b2ce2a37d921b5ad88fc38663fc0ff3dd6c582d1
      * @return ProductScopeRewriteGenerator|mixed
      */
     private function getProductScopeRewriteGenerator()
@@ -154,23 +164,20 @@ public function generate(Product $product, $rootCategoryId = null)
             }
         }
 
-        $storeId = $product->getStoreId();
         $productCategories = $product->getCategoryCollection()
             ->addAttributeToSelect('url_key')
             ->addAttributeToSelect('url_path');
 
-        $urls = $this->isGlobalScope($storeId)
-            ? $this->generateForGlobalScope($productCategories, $product, $rootCategoryId)
-            : $this->generateForSpecificStoreView($storeId, $productCategories, $product, $rootCategoryId);
-
-        return $urls;
+        // Generate url rewrites for all store views to ensure store views with different url-key are generated as well.
+        return $this->generateForGlobalScope($productCategories, $product, $rootCategoryId);
     }
 
     /**
      * Check is global scope
      *
      * @deprecated 100.1.4
      * @see not used
+     * @see https://github.com/magento/magento2/commit/b2ce2a37d921b5ad88fc38663fc0ff3dd6c582d1
      * @param int|null $storeId
      * @return bool
      */
@@ -184,6 +191,7 @@ protected function isGlobalScope($storeId)
      *
      * @deprecated 100.1.4
      * @see not used
+     * @see https://github.com/magento/magento2/commit/b2ce2a37d921b5ad88fc38663fc0ff3dd6c582d1
      * @param \Magento\Framework\Data\Collection $productCategories
      * @param \Magento\Catalog\Model\Product|null $product
      * @param int|null $rootCategoryId
@@ -203,6 +211,7 @@ protected function generateForGlobalScope($productCategories, $product = null, $
      *
      * @deprecated 100.1.4
      * @see not used
+     * @see https://github.com/magento/magento2/commit/b2ce2a37d921b5ad88fc38663fc0ff3dd6c582d1
      * @param int $storeId
      * @param \Magento\Framework\Data\Collection $productCategories
      * @param Product|null $product
@@ -220,10 +229,14 @@ protected function generateForSpecificStoreView(
     }
 
     /**
+     * Checking the category is generating correctly
+     *
+     * @deprecated 100.1.4
      * Check if category should have url rewrites
      *
      * @deprecated 100.1.4
      * @see not used
+     * @see https://github.com/magento/magento2/commit/b2ce2a37d921b5ad88fc38663fc0ff3dd6c582d1
      * @param \Magento\Catalog\Model\Category $category
      * @param int $storeId
      * @return bool

app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductUrlRewriteGeneratorTest.php

@@ -134,15 +134,11 @@ public function testGenerate()
         $productMock = $this->getMockBuilder(Product::class)
             ->disableOriginalConstructor()
             ->getMock();
-        $storeId = 1;
         $urls = ['dummy-url.html'];
 
         $productMock->expects($this->once())
             ->method('getVisibility')
             ->willReturn(2);
-        $productMock->expects($this->once())
-            ->method('getStoreId')
-            ->willReturn($storeId);
         $productCategoriesMock = $this->getMockBuilder(Collection::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -156,7 +152,7 @@ public function testGenerate()
             ->method('getCategoryCollection')
             ->willReturn($productCategoriesMock);
         $this->productScopeRewriteGenerator->expects($this->once())
-            ->method('generateForSpecificStoreView')
+            ->method('generateForGlobalScope')
             ->willReturn($urls);
         $this->assertEquals($urls, $this->productUrlRewriteGenerator->generate($productMock, 1));
     }

app/code/Magento/UrlRewrite/Test/Mftf/Test/AdminProductCreateUrlRewriteForCustomStoreViewTest.xml

@@ -90,8 +90,10 @@
             <argument name="category" value="$$createCategory$$"/>
             <argument name="product" value="$$createProductForUrlRewrite$$"/>
         </actionGroup>
-         <actionGroup ref="StorefrontCheckProductUrlActionGroup" stepKey="checkProductWithChangedUrl">
-            <argument name="productUrl" value="$$createProductForUrlRewrite.custom_attributes[url_key]$$"/>
+         <actionGroup ref="AssertStorefrontProductRedirectActionGroup" stepKey="checkProductWithChangedUrl">
+             <argument name="productName" value="$$createProductForUrlRewrite.name$$"/>
+             <argument name="productSku" value="$$createProductForUrlRewrite.sku$$"/>
+             <argument name="productRequestPath" value="u2.html"/>
         </actionGroup>
         <!--Step 8. On Storefront switch on created Custom Store View -->
         <actionGroup ref="StorefrontSwitchStoreViewActionGroup" stepKey="switchToCustomStoreViewOnStorefront">

dev/tests/integration/testsuite/Magento/CatalogUrlRewrite/Model/ProductUrlRewriteTest.php

@@ -175,11 +175,6 @@ public static function productEditProvider(): array
                         'request_path' => 'new-url-key%suffix%',
                         'target_path' => 'catalog/product/view/id/%id%',
                     ],
-                    [
-                        'request_path' => 'simple-product%suffix%',
-                        'target_path' => 'new-url-key%suffix%',
-                        'redirect_type' => OptionProvider::PERMANENT,
-                    ],
                 ],
             ],
         ];