Check if OpenGraph can show price #38510

barryvdh · 2024-03-11T14:21:34Z

Description (*)

This checks if the price can be shown

Manual testing scenarios (*)

Create a plugin which hides the price, or use https://github.com/karliuka/m2.ProductAvailable
Check that the price is hidden
Check that without this change, the price is still visible in the OG tag.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Check if OpenGraph can show price #38512: Check if OpenGraph can show price

m2-assistant · 2024-03-11T14:21:38Z

Hi @barryvdh. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

barryvdh · 2024-03-11T14:24:41Z

@magento run all tests

engcom-Hotel · 2024-03-12T11:04:34Z

@magento create issue

barryvdh · 2024-05-03T07:27:03Z

@magento run WebAPI Tests

engcom-Hotel · 2025-05-15T05:30:46Z

@magento run all tests

engcom-Hotel

Hello @barryvdh,

Thanks for the contribution!

Please fix the failed static tests, other failed tests seems flaky to me.

Thanks

barryvdh · 2025-05-15T11:02:09Z

Hello @barryvdh,

Thanks for the contribution!

Please fix the failed static tests, other failed tests seems flaky to me.

Thanks

Do you mean this error?

That doesn't seem relevant to my PR, or do you need me to fix the rest of the template?

engcom-Hotel · 2025-05-15T11:06:31Z

Hello @barryvdh,

I agree that the failures are not related to your changes, but we need a green build to proceed further with this.

Thanks

barryvdh · 2025-05-15T11:19:34Z

@magento run static tests

barryvdh · 2025-05-15T12:30:34Z

@magento run all tests

barryvdh · 2025-05-15T14:20:19Z

@magento run all tests

engcom-Hotel

Hello @barryvdh,

Thanks for the making the changes, one more small change is required as suggested below.

Please do the needful.

Thanks

app/code/Magento/Catalog/view/frontend/templates/product/view/opengraph/general.phtml

…opengraph/general.phtml Co-authored-by: Abhinav Pathak <51681618+engcom-Hotel@users.noreply.github.com>

barryvdh · 2025-05-16T06:15:16Z

@magento run all tests

barryvdh · 2025-05-16T11:57:00Z

@engcom-Hotel all good now?

engcom-Hotel · 2025-05-19T04:57:43Z

@magento run Functional Tests B2B, Functional Tests CE, Unit Tests

engcom-Bravo · 2025-05-20T10:18:33Z

@magento run all tests

engcom-Bravo · 2025-05-20T12:12:59Z

Hi @barryvdh,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Steps to reproduce

Create a plugin which hides the price, or use https://github.com/karliuka/m2.ProductAvailable
Check that the price is hidden
Check that without this change, the price is still visible in the OG tag

Before: ✖️

After: ✔️

price is not visible in the OG tag.

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

engcom-Dash · 2025-05-23T06:25:03Z

@magento run all tests

engcom-Dash · 2025-05-23T08:45:23Z

@magento run Unit Tests, Functional Tests B2B, Functional Tests EE, Functional Tests CE

engcom-Dash · 2025-05-23T11:33:31Z

The consistent test failures for Functional B2B are known Issues and JIRA is raised for them. Other failures are inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38510/5ca8272b8857988043cdae955df852d5/Functional/allure-report-b2b/index.html#categories/ba729ce87e7059ef4466d4300850777a/722ee95bc7de6136/

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38510/d10ae97404e2930646afc457cebd1ed2/Functional/allure-report-b2b/index.html#categories/ba729ce87e7059ef4466d4300850777a/15276744294c5a42/

Known Issues:
OrderWithMultipleConfigurableProductsAdditionalStockTest : ACQE-8060
EnablePaypalExpressCheckoutAndSubmitAnOrderUsingPaypalExpressCheckoutTest : ACQE-8007
StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest : ACQE-7971

The consistent test failure for Functional CE is known Issues and JIRA is raised for the same.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38510/ca591881f4de4023cba453a622039d61/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38510/2a15ee83cd96cf22a4fa170076e4bd6f/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issues:
EnablePaypalExpressCheckoutAndSubmitAnOrderUsingPaypalExpressCheckoutTest : ACQE-8007

engcom-Dash · 2025-05-23T11:40:24Z

The consistent test failure for Functional EE is known Issues and JIRA is raised for the same. Other failure is inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38510/b780ede4c5d83a4438f07e581d47f592/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38510/86e60bf286aaad1ca64bf0bcaaadb5e3/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issues:
EnablePaypalExpressCheckoutAndSubmitAnOrderUsingPaypalExpressCheckoutTest : ACQE-8007

Hence moving this PR in Merge In Progress.

engcom-Dash · 2025-06-17T06:34:08Z

@magento run all tests

Check if OpenGraph can show price

f6f7ef2

engcom-Hotel added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 12, 2024

m2-assistant bot mentioned this pull request Mar 12, 2024

[Issue] Check if OpenGraph can show price #38512

Open

5 tasks

m2-community-project bot added the Progress: pending review label Mar 12, 2024

engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 12, 2024

engcom-Charlie added the Project: Community Picked PRs upvoted by the community label May 13, 2025

engcom-Charlie added this to Community Dashboard May 13, 2025

engcom-Charlie moved this to Pending Review in Community Dashboard May 13, 2025

Merge branch '2.4-develop' into patch-4

91f3b68

engcom-Hotel requested changes May 15, 2025

View reviewed changes

engcom-Hotel moved this from Pending Review to Changes Requested in Community Dashboard May 15, 2025

ct-prd-projects-boards-automation bot added the Progress: needs update label May 15, 2025

Fix static tests

19ed54c

Shorten

2b7c936

engcom-Hotel requested changes May 16, 2025

View reviewed changes

app/code/Magento/Catalog/view/frontend/templates/product/view/opengraph/general.phtml Outdated Show resolved Hide resolved

Update app/code/Magento/Catalog/view/frontend/templates/product/view/…

6216ba1

…opengraph/general.phtml Co-authored-by: Abhinav Pathak <51681618+engcom-Hotel@users.noreply.github.com>

engcom-Hotel approved these changes May 19, 2025

View reviewed changes

ct-prd-projects-boards-automation bot moved this from Changes Requested to Ready for Testing in Community Dashboard May 19, 2025

ct-prd-projects-boards-automation bot added Progress: ready for testing Progress: review and removed Progress: needs update Progress: pending review labels May 19, 2025

ct-prd-projects-boards-automation bot moved this from Ready for Testing to Review in Progress in Community Dashboard May 19, 2025

engcom-Hotel moved this from Review in Progress to Ready for Testing in Community Dashboard May 19, 2025

ct-prd-projects-boards-automation bot removed the Progress: review label May 19, 2025

Merge branch '2.4-develop' into patch-4

6d841d0

engcom-Bravo self-assigned this May 20, 2025

ct-prd-projects-boards-automation bot added the Progress: testing in progress label May 20, 2025

engcom-Bravo removed Progress: testing in progress Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it labels May 20, 2025

ct-prd-projects-boards-automation bot removed the Progress: ready for testing label May 20, 2025

engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard May 20, 2025

engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard May 20, 2025

engcom-Dash self-assigned this May 22, 2025

Merge branch '2.4-develop' into patch-4

948fdeb

engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard May 23, 2025

Merge branch '2.4-develop' into patch-4

60c0864

Check if OpenGraph can show price #38510

Are you sure you want to change the base?

Check if OpenGraph can show price #38510

Uh oh!

Conversation

barryvdh commented Mar 11, 2024 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Manual testing scenarios (*)

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Mar 11, 2024

Uh oh!

barryvdh commented Mar 11, 2024

Uh oh!

engcom-Hotel commented Mar 12, 2024

Uh oh!

barryvdh commented May 3, 2024

Uh oh!

engcom-Hotel commented May 15, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

barryvdh commented May 15, 2025

Uh oh!

engcom-Hotel commented May 15, 2025

Uh oh!

barryvdh commented May 15, 2025

Uh oh!

barryvdh commented May 15, 2025

Uh oh!

barryvdh commented May 15, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

barryvdh commented May 16, 2025

Uh oh!

barryvdh commented May 16, 2025

Uh oh!

engcom-Hotel commented May 19, 2025

Uh oh!

engcom-Bravo commented May 20, 2025

Uh oh!

engcom-Bravo commented May 20, 2025

✔️ QA Passed

Uh oh!

engcom-Dash commented May 23, 2025

Uh oh!

engcom-Dash commented May 23, 2025

Uh oh!

engcom-Dash commented May 23, 2025

Uh oh!

engcom-Dash commented May 23, 2025

Uh oh!

engcom-Dash commented Jun 17, 2025

Uh oh!

Uh oh!

barryvdh commented Mar 11, 2024 •

edited by m2-assistant bot

Loading