-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix case insensitive SQL fiter(where) condition #39879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @Genaker. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Hello @Genaker, Please provide some more information on this PR like;
Thanks |
See #39878 (comment) Looks like bad usage of Magento internal. |
SQL commands must be not case insensitive or doesn't generate wrong SQL if can't find command. it is critical core bug here |
or you can also make this for edge case:
$key = key(array_intersect_key($condition, $conditionKeyMap));
if(!$key) {
$condition = array_change_key_case($condition, CASE_LOWER);
$key = key(array_intersect_key($condition, $conditionKeyMap));
}
Even like this will be even better: