magento/magento2#39729: Cannot return null for non-nullable field "SelectedCustomizableOption.label"

[KrasnoshchokBohdan]

Description (*)

Skip any deleted/invalid custom options instead of including them in the result
\Magento\QuoteGraphQl\Model\Resolver\CustomizableOptions::resolve

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#39729

Manual testing scenarios (*)

1. create custom options in products A and B
2. add to cart products A and B
3. remove custom options from product A or B
4. attempt to get the cart using graphql

  cart(cart_id: "xxxx") {
    items {
      ... on SimpleCartItem {
        customizable_options {
          label
          values {
            label
            value
          }
        }
      }
    }
  }
}

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[KrasnoshchokBohdan]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @KrasnoshchokBohdan,

Thanks for the contribution!

The code changes seems good to us, but please add some automated test in accordance to the DOD.

Thanks

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run Static Tests

[KrasnoshchokBohdan]

@magento run Static Tests

[KrasnoshchokBohdan]

@magento run Database Compare, Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Magento Health Index, Sample Data Tests B2B, Sample Data Tests CE, Sample Data Tests EE, Semantic Version Checker, Unit Tests, WebAPI Tests

[KrasnoshchokBohdan]

@magento run WebAPI Tests

[engcom-Hotel]

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE

[engcom-Bravo]

@magento run all tests

[engcom-Bravo]

Hi @KrasnoshchokBohdan,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• create custom options in products A and B
• add to cart products A and B
• remove custom options from product A or B
• attempt to get the cart using graphql

cart(cart_id: "xxxx") {
   items {
     ... on SimpleCartItem {
       customizable_options {
         label
         values {
           label
           value
         }
       }
     }
   }
 }
}

Before: ✖️ 

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.