-
Notifications
You must be signed in to change notification settings - Fork 9.4k
magento/magento2#38798: Cannot change column type in some cases #39932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
magento/magento2#38798: Cannot change column type in some cases #39932
Conversation
- changed 'note' column type from varchar to text, removed length attribute
Hi @KrasnoshchokBohdan. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento run all tests |
@magento run all tests |
Description (*)
Error happens here
vendor/magento/framework/Config/Reader/Filesystem.php 186
As the author of the issue noticed, an interesting solution is proposed in
#26155 (comment)
but for now I'll just stick to changing the type, if there are other suggestions I'll be happy to consider them
https://developer.adobe.com/commerce/php/development/components/declarative-schema/configuration/#change-the-column-type
Related Pull Requests
26160
Fixed Issues (if relevant)
Manual testing scenarios (*)
1.create new module, or use existing one from app/code/
2.add this snippet to db_schema.xml
<table name="eav_attribute"> <column xsi:type="text" name="note" nullable="true" comment="Note"/> </table>
3.use bin/magento setup:upgrade command
4.see error "Element 'column', attribute 'length': The attribute 'length' is not allowed."
Questions or comments
Contribution checklist (*)