matthiasmullie/minify - replacing JS & CSS libraries with a better one

[jakwinkler]

Description (*)

I've replaced old CSS / JS minification libraries with https://github.com/matthiasmullie/minify - which is maintained, up to date and covered with tests.

Fixed Issues (if relevant)

1. Fixes Consider moving from tedivm/jshrink to garfix/js-minify #34309

Manual testing scenarios (*)

1. enable CSS minification
2. enable JS minification
3. enable production mode
4. test frontend, backend

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @jakwinkler. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[jakwinkler]

@magento run all tests

[Den4ik]

@magento run all tests

[Copilot]

Pull Request Overview

This pull request replaces the legacy JShrink and CSSmin libraries with the maintained matthiasmullie/minify package for JavaScript and CSS minification.

• JS adapter updated to use MatthiasMullie\Minify\JS
• CSS adapter simplified to use MatthiasMullie\Minify\CSS
• Added matthiasmullie/minify to composer.json and reordered dependencies

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File	Description
lib/internal/Magento/Framework/Code/Minifier/Adapter/Js/JShrink.php	Switched import and implementation to use Minify\JS
lib/internal/Magento/Framework/Code/Minifier/Adapter/Css/CSSmin.php	Removed legacy CSSmin code and used Minify\CSS
composer.json	Added matthiasmullie/minify and reorganized dependencies

Comments suppressed due to low confidence (1)

lib/internal/Magento/Framework/Code/Minifier/Adapter/Css/CSSmin.php:22

• [nitpick] Add unit tests for this new CSS minifier adapter to verify it handles various CSS inputs correctly.

    public function minify($content): string

[Copilot]

The return type includes bool but the implementation always returns a string. Change the signature to : string for accuracy.

Suggested change

	public function minify($content): bool|string
	public function minify($content): string

[Copilot]

[nitpick] Import the JS-specific class directly with use MatthiasMullie\Minify\JS; and instantiate new JS() to improve clarity.

Suggested change

	use MatthiasMullie\Minify;
	use MatthiasMullie\Minify\JS;

[Copilot]

[nitpick] Dependencies in composer.json appear out of alphabetical order; consider sorting entries to improve readability.

[ihor-sviziev]

@jakwinkler, please review the comments from Copilot and let us know if you would like anything to be fixed based on them. If no, I'll review the pull request

[Den4ik]

@magento run all tests