Skip to content

Cannot filter on options with a "," #4304

Closed
@vacla

Description

@vacla

Describe the bug

After selecting a category with a "," on the category page, no results are found or wrong results shown.
This is very likey due to the delimiter being a "," here: https://github.com/magento/pwa-studio/blob/develop/packages/peregrine/lib/talons/FilterModal/helpers.js#L1

To reproduce

Steps to reproduce the behavior:

  1. Go to category page
  2. Click on filter with a ","
  3. No results found or not showing correct results

Expected behavior

Show results of that category

Debug Report

`
ℹ Inspecting Dependencies
Found 9 @magento dependencies in yarn.lock
@magento/pwa-buildpack @ 11.4.3
@adobe/apollo-link-mutation-queue @ 1.0.2
@magento/babel-preset-peregrine @ 1.2.3
@magento/eslint-config @ 1.5.3
@magento/pagebuilder @ 8.2.1
@magento/peregrine @ 13.2.1
@magento/pwa-theme-venia @ 1.4.0
@magento/venia-adobe-data-layer @ 1.0.0
@magento/venia-ui @ 10.3.0

ℹ Inspecting Magento Backend
Not using sample backend.
Backend is UP!

ℹ Inspecting System
OS: #39-Ubuntu SMP PREEMPT_DYNAMIC Fri Jul 5 21:49:14 UTC 2024
Node Version: v16.20.2
NPM Version: 8.19.4

`

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]: PC
  • Browser [e.g. Chrome, Safari]: Chrome
  • Browser Version [e.g. 22]: 127.0.6533.72
  • Magento Version [e.g Adobe Commerce 2.4]: commerce 2.4.5-p8

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa

Metadata

Metadata

Assignees

Labels

Issue: Needs UpdateAdditional information is require, waiting for responseProgress: donebugSomething isn't workingissue: Cannot Reproducewhen issue not reproducible by internal team they might required additional info or steps missing

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions