Skip to content

[bug]: Infinite loop query GetWishlistItemsForLocalField #4365

Open
@joseamietta

Description

@joseamietta

query GetWishlistItemsForLocalField run in loop freezed the home page

As a logged customer, I added more than 10 items in one wishlist. Then, in the home page created more than one product carousel, the query GetWishlistItemsForLocalField runs in a loop freezes the page.

To reproduce

Steps to reproduce the behavior:

  1. in the administrator, add 2 product carousel to the home page
  2. Loggin as a customer in store front
  3. Add 11 (eleven) products in one wishlist
  4. After that, go to the homepage and you'll se in the network inspector the query GetWishlistItemsForLocalField runs in a loop

Screenshots

Screenshot from 2024-12-26 15-54-12

Possible solutions

The hook useCustomerWishlistSkus is called from useCarousel and run multiple times. Move this hook outside of Carousel component

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]: Laptop
  • Browser [e.g. Chrome, Safari]: Chome
  • Browser Version [e.g. 22]: Version 131.0.6778.108 (Official Build) (64-bit)
  • Magento Version [e.g Adobe Commerce 2.4]: 2.4.7

Please let us know what packages this bug is in regards to:

  • venia-concept
    venia-ui
    pwa-buildpack
    peregrine
    pwa-devdocs
    upward-js
    upward-spec
    create-pwa

Activity

m2-assistant

m2-assistant commented on Dec 26, 2024

@m2-assistant

Hi @joseamietta. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

joseamietta

joseamietta commented on Dec 26, 2024

@joseamietta
Author

@magento I am working on this

linked a pull request that will close this issue on Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @joseamietta

    Issue actions

      [bug]: Infinite loop query GetWishlistItemsForLocalField · Issue #4365 · magento/pwa-studio