Skip to content

Update README.md #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Update README.md #4454

merged 2 commits into from
Apr 7, 2025

Conversation

glo80684
Copy link
Collaborator

@glo80684 glo80684 commented Mar 20, 2025

Description

Adding "postcss.config.js" in prod.dockerfile to copy css configs during builds to fix ui distortion issue.

Related Issue

https://jira.corp.adobe.com/browse/PWA-3352

Closes #PWA-3352.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 20, 2025

Messages
📖

Associated JIRA tickets: PWA-3352.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 499f99a

Copy link
Collaborator

@del15881 del15881 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have checked as requested.

@del15881 del15881 added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 24, 2025
@del15881 del15881 closed this Mar 24, 2025
@del15881 del15881 reopened this Mar 24, 2025
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 499f99a

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 24, 2025

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • lets users add products to cart regardless of store view:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="Header-root"] [data-cy="CartTrigger-counter"]`, but never found it.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 499f99a

@glo80684 glo80684 closed this Mar 24, 2025
@glo80684 glo80684 reopened this Mar 24, 2025
@glo42707
Copy link
Collaborator

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 25, 2025

Successfully started codebuild job for pr-test

@glo82145 glo82145 merged commit 8fce578 into develop Apr 7, 2025
6 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants